We add a button in other places (e.g. Network tab, Audit tab), and we should be consistent.
Created attachment 355524 [details] Patch
Created attachment 355525 [details] [Image] After Patch is applied
Comment on attachment 355524 [details] Patch Attachment 355524 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10122943 New failing tests: media/no-fullscreen-when-hidden.html
Created attachment 355540 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 355524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355524&action=review r=me > Source/WebInspectorUI/UserInterface/Views/FilterBarButton.js:46 > + toggle(value) Would it be easier to add a new function? Reset?
Comment on attachment 355524 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355524&action=review >> Source/WebInspectorUI/UserInterface/Views/FilterBarButton.js:46 >> + toggle(value) > > Would it be easier to add a new function? Reset? I think this better matches the DOM `classList` API, so I'd prefer to keep it as is. Additionally, this means that there is a single path for all functionality, which should make future maintenance easier :)
Comment on attachment 355524 [details] Patch Clearing flags on attachment: 355524 Committed r238502: <https://trac.webkit.org/changeset/238502>
All reviewed patches have been landed. Closing bug.
<rdar://problem/46249823>