Bug 191913 - Address post-review feedback after r238438
Summary: Address post-review feedback after r238438
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-22 12:09 PST by Wenson Hsieh
Modified: 2018-11-22 19:11 PST (History)
6 users (show)

See Also:


Attachments
Patch (40.50 KB, patch)
2018-11-22 16:24 PST, Wenson Hsieh
rniwa: review+
Details | Formatted Diff | Diff
Try to fix Win build (41.81 KB, patch)
2018-11-22 17:22 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-22 12:09:07 PST
• Make Editor::setSelectedRange take enum classes instead of bools.
• Make Editor::replaceSelectionWithText take enum classes instead of bools.
• Don't pass in Vector&&s for a few functions that don't take ownership of the Vector.
• ...and a couple of other small items.
Comment 1 Wenson Hsieh 2018-11-22 12:36:41 PST
(In reply to Wenson Hsieh from comment #0)
> • Make Editor::setSelectedRange take enum classes instead of bools.

I meant to write `FrameSelection::setSelectedRange`.

> • Make Editor::replaceSelectionWithText take enum classes instead of bools.
> • Don't pass in Vector&&s for a few functions that don't take ownership of
> the Vector.
> • ...and a couple of other small items.
Comment 2 Wenson Hsieh 2018-11-22 16:24:14 PST
Created attachment 355491 [details]
Patch
Comment 3 Wenson Hsieh 2018-11-22 17:22:19 PST
Created attachment 355494 [details]
Try to fix Win build
Comment 4 WebKit Commit Bot 2018-11-22 19:10:41 PST
Comment on attachment 355494 [details]
Try to fix Win build

Clearing flags on attachment: 355494

Committed r238454: <https://trac.webkit.org/changeset/238454>
Comment 5 Radar WebKit Bug Importer 2018-11-22 19:11:32 PST
<rdar://problem/46216836>