Bug 191908 – UI side compositing doesn't paint on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

It tries to use unsupported IOSurface formats.

[Antti Koivisto]

Created attachment 355475 [details]
patch

[Sam Weinig]

Comment on attachment 355475 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355475&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.h:53
> +#if PLATFORM(IOS_FAMILY)

It seems like this would be a bit nicer if it was HAVE(IOSURFACE_RBA10) or something like that.

[Antti Koivisto]

(In reply to Sam Weinig from comment #2)
> Comment on attachment 355475 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355475&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/IOSurface.h:53
> > +#if PLATFORM(IOS_FAMILY)
> 
> It seems like this would be a bit nicer if it was HAVE(IOSURFACE_RBA10) or
> something like that.

Maybe though I kinda hate trying to figure out what those mean.

[Antti Koivisto]

Created attachment 355479 [details]
with HAVE_IOSURFACE_RGB10

[Tim Horton]

Comment on attachment 355479 [details]
with HAVE_IOSURFACE_RGB10

View in context: https://bugs.webkit.org/attachment.cgi?id=355479&action=review

> Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:505
> +#if HAVE(IOSURFACE_RGB10)

All seems a bit overkill when you could have just done this one.

Also we probably want something different here so we're not just using RGBA on wide-color macOS? But that's a separate problem.

[EWS Watchlist]

Comment on attachment 355479 [details]
with HAVE_IOSURFACE_RGB10

Attachment 355479 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10113349

New failing tests:
media/no-fullscreen-when-hidden.html

[EWS Watchlist]

Created attachment 355492 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Antti Koivisto]

> All seems a bit overkill when you could have just done this one.

I like having compiler check for correctness when possible.

> Also we probably want something different here so we're not just using RGBA
> on wide-color macOS? But that's a separate problem.

Yep. I'm bit confused why all these deep color bits are set on Mac but then we don't actually use deep color backing stores.

[WebKit Commit Bot]

Comment on attachment 355479 [details]
with HAVE_IOSURFACE_RGB10

Clearing flags on attachment: 355479

Committed r238459: <https://trac.webkit.org/changeset/238459>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46222543>