Bug 191904 - [GStreamer][WebRTC] Do not run device monitor for device type we do not handle
Summary: [GStreamer][WebRTC] Do not run device monitor for device type we do not handle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-22 05:00 PST by Thibault Saunier
Modified: 2018-11-28 04:41 PST (History)
3 users (show)

See Also:

Attachments
Minor ChangeLog enhancement (1.82 KB, patch)
2018-11-22 05:00 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (2.00 KB, patch)
2018-11-27 12:08 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-11-22 05:00:05 PST 
[GStreamer][WebRTC] Do not run device monitor for device type we do not handle
Comment 1 Thibault Saunier 2018-11-22 05:00:42 PST 
Created attachment 355468 [details]
Minor ChangeLog enhancement
Comment 2 Philippe Normand 2018-11-22 06:10:57 PST 
Comment on attachment 355468 [details]
Minor ChangeLog enhancement

View in context: https://bugs.webkit.org/attachment.cgi?id=355468&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:113
> +        } else {
> +            return;
>          }

The curly braces can be removed :)

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:-112
> -        // FIXME: Add monitor for added/removed messages on the bus.

Why is this removed? Doesn't need to be fixed?
Comment 3 Thibault Saunier 2018-11-27 12:06:56 PST 
(In reply to Philippe Normand from comment #2)
> Comment on attachment 355468 [details]
> Minor ChangeLog enhancement
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355468&action=review
> 
> > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:113
> > +        } else {
> > +            return;
> >          }
> 
> The curly braces can be removed :)

Done.

> > Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:-112
> > -        // FIXME: Add monitor for added/removed messages on the bus.
> 
> Why is this removed? Doesn't need to be fixed?

Right, just moving it and forgot to commit the addition. Re added now.
Comment 4 Thibault Saunier 2018-11-27 12:08:12 PST 
Created attachment 355758 [details]
Patch
Comment 5 WebKit Commit Bot 2018-11-28 04:40:16 PST 
Comment on attachment 355758 [details]
Patch

Clearing flags on attachment: 355758

Committed r238605: <https://trac.webkit.org/changeset/238605>
Comment 6 WebKit Commit Bot 2018-11-28 04:40:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-28 04:41:36 PST 
<rdar://problem/46306708>