Bug 191896 - [LFC] LayoutState should always be initialized with the initial containing block.
Summary: [LFC] LayoutState should always be initialized with the initial containing bl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-21 14:36 PST by zalan
Modified: 2018-11-21 15:26 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.44 KB, patch)
2018-11-21 14:52 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-11-21 14:36:00 PST 
and not with some random formatting context root.
Comment 1 zalan 2018-11-21 14:52:09 PST 
Created attachment 355440 [details]
Patch
Comment 2 Antti Koivisto 2018-11-21 15:12:10 PST 
Comment on attachment 355440 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355440&action=review

> Source/WebCore/layout/Verification.cpp:324
> +    auto& initialContainingBlock = *m_initialContainingBlock;

The local here doesn't do much.
Comment 3 zalan 2018-11-21 15:25:19 PST 
Committed r238431: <https://trac.webkit.org/changeset/238431>
Comment 4 Radar WebKit Bug Importer 2018-11-21 15:26:29 PST 
<rdar://problem/46205042>