Bug 191886 – [WebRTC][GStreamer] fast/mediastream/MediaStream-video-element-remove-track.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alicia Boya García]

fast/mediastream/MediaStream-video-element-remove-track.html is failing since r238276-238281

--- /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/layout-test-results/fast/mediastream/MediaStream-video-element-remove-track-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/layout-test-results/fast/mediastream/MediaStream-video-element-remove-track-actual.txt
@@ -39,7 +39,7 @@
 PASS video.videoTracks[0].kind is "main"
 
 **** check no audio track ****
-PASS video.audioTracks.length is 0
+FAIL video.audioTracks.length should be 0. Was 1.
 PASS mediaStream.getAudioTracks().length is 0
 PASS successfullyParsed is true

[Philippe Normand]

Created attachment 431662 [details]
Patch

[Philippe Normand]

Created attachment 431664 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 431664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431664&action=review

> Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:369
> +    auto source = WTFMove(priv->sources[index]);

Please, specify the type here, just in case.

[Philippe Normand]

(In reply to Xabier Rodríguez Calvar from comment #3)
> Comment on attachment 431664 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431664&action=review
> 
> > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:369
> > +    auto source = WTFMove(priv->sources[index]);
> 
> Please, specify the type here, just in case.

In case of?
There is no ambiguity in this case, otherwise the code wouldn't compile. But yeah sure, let's do this just in case :)

[Philippe Normand]

Committed r279033 (238953@main): <https://commits.webkit.org/238953@main>