Bug 191881 - Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: baseline
Summary: Tables with vertical-lr writing-mode doesn't apply correctly vertical-align: ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-21 05:52 PST by Javier Fernandez
Modified: 2018-11-22 00:46 PST (History)
10 users (show)

See Also:


Attachments
Test case to reproduce the issue (137 bytes, text/html)
2018-11-21 05:52 PST, Javier Fernandez
no flags Details
Expected result (3.76 KB, image/png)
2018-11-21 05:53 PST, Javier Fernandez
no flags Details
Actual result (4.95 KB, image/png)
2018-11-21 05:53 PST, Javier Fernandez
no flags Details
Test case to reproduce the issue (283 bytes, text/html)
2018-11-21 06:02 PST, Javier Fernandez
no flags Details
Patch (60.29 KB, patch)
2018-11-21 07:54 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-sierra-wk2 (2.98 MB, application/zip)
2018-11-21 09:07 PST, Build Bot
no flags Details
Archive of layout-test-results from ews204 for win-future (12.87 MB, application/zip)
2018-11-21 09:54 PST, Build Bot
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.55 MB, application/zip)
2018-11-21 10:00 PST, Build Bot
no flags Details
Patch (115.31 KB, patch)
2018-11-21 13:59 PST, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2018-11-21 05:52:39 PST
Created attachment 355404 [details]
Test case to reproduce the issue

What steps will reproduce the problem?
(1) Load the attached test case
(2)
(3)

What is the expected output?

The elements on each column should be aligned using their alphabetic baselines (expected.png)

What do you see instead?

The items are not aligned at all; the table may be using hanging baseline, but not sure (result.png)
Comment 1 Javier Fernandez 2018-11-21 05:53:15 PST
Created attachment 355405 [details]
Expected result
Comment 2 Javier Fernandez 2018-11-21 05:53:34 PST
Created attachment 355406 [details]
Actual result
Comment 3 Javier Fernandez 2018-11-21 06:02:42 PST
Created attachment 355407 [details]
Test case to reproduce the issue
Comment 4 Javier Fernandez 2018-11-21 07:54:35 PST
Created attachment 355411 [details]
Patch
Comment 5 Manuel Rego Casasnovas 2018-11-21 08:08:41 PST
Comment on attachment 355411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355411&action=review

LGTM, I guess you still need to add the new results for other platforms before landing.

> LayoutTests/fast/writing-mode/vertical-align-table-baseline-latin-expected.html:8
> +</style>

Nit: I'd add the typical paragraph about when this passes.
Comment 6 Build Bot 2018-11-21 09:07:35 PST
Comment on attachment 355411 [details]
Patch

Attachment 355411 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10099721

New failing tests:
fast/writing-mode/vertical-align-table-baseline-latin.html
Comment 7 Build Bot 2018-11-21 09:07:36 PST
Created attachment 355420 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 Build Bot 2018-11-21 09:54:03 PST
Comment on attachment 355411 [details]
Patch

Attachment 355411 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10100233

New failing tests:
fast/writing-mode/vertical-align-table-baseline.html
Comment 9 Build Bot 2018-11-21 09:54:14 PST
Created attachment 355423 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 10 Build Bot 2018-11-21 10:00:42 PST
Comment on attachment 355411 [details]
Patch

Attachment 355411 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10099992

New failing tests:
fast/writing-mode/vertical-align-table-baseline-latin.html
Comment 11 Build Bot 2018-11-21 10:00:44 PST
Created attachment 355425 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 12 Javier Fernandez 2018-11-21 13:59:09 PST
Created attachment 355438 [details]
Patch
Comment 13 WebKit Commit Bot 2018-11-22 00:45:55 PST
Comment on attachment 355438 [details]
Patch

Clearing flags on attachment: 355438

Committed r238441: <https://trac.webkit.org/changeset/238441>
Comment 14 WebKit Commit Bot 2018-11-22 00:45:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-11-22 00:46:41 PST
<rdar://problem/46209667>