WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
191873
[LFC][IFC] Take nonBreakableStart/End into use.
https://bugs.webkit.org/show_bug.cgi?id=191873
Summary
[LFC][IFC] Take nonBreakableStart/End into use.
zalan
Reported
2018-11-20 20:30:51 PST
to offset the final inline runs.
Attachments
Patch
(25.40 KB, patch)
2018-11-20 21:50 PST
,
zalan
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2018-11-20 21:50:28 PST
Created
attachment 355383
[details]
Patch
Antti Koivisto
Comment 2
2018-11-21 06:52:05 PST
Comment on
attachment 355383
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=355383&action=review
> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:148 > unsigned uncommittedLength = 0; > InlineItem* firstUncommittedInlineItem = nullptr; > + InlineItem* lastUncommittedInlineItem = nullptr;
Maybe these could alternatively be something like struct Uncommitted { unsigned length { 0 }; InlineItem& firstInlineItem; InlineItem& lastInlineItem; }; std::optional<Uncommitted> uncommitted; since these are always used together?
zalan
Comment 3
2018-11-21 07:41:52 PST
Committed
r238415
: <
https://trac.webkit.org/changeset/238415
>
Radar WebKit Bug Importer
Comment 4
2018-11-21 07:42:29 PST
<
rdar://problem/46201523
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug