Bug 191873 - [LFC][IFC] Take nonBreakableStart/End into use.
Summary: [LFC][IFC] Take nonBreakableStart/End into use.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-20 20:30 PST by zalan
Modified: 2018-11-21 07:42 PST (History)
5 users (show)

See Also:

Attachments
Patch (25.40 KB, patch)
2018-11-20 21:50 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-11-20 20:30:51 PST 
to offset the final inline runs.
Comment 1 zalan 2018-11-20 21:50:28 PST 
Created attachment 355383 [details]
Patch
Comment 2 Antti Koivisto 2018-11-21 06:52:05 PST 
Comment on attachment 355383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355383&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:148
>      unsigned uncommittedLength = 0;
>      InlineItem* firstUncommittedInlineItem = nullptr;
> +    InlineItem* lastUncommittedInlineItem = nullptr;

Maybe these could alternatively be something like

struct Uncommitted { unsigned length { 0 }; InlineItem& firstInlineItem; InlineItem& lastInlineItem; };
std::optional<Uncommitted> uncommitted;

since these are always used together?
Comment 3 zalan 2018-11-21 07:41:52 PST 
Committed r238415: <https://trac.webkit.org/changeset/238415>
Comment 4 Radar WebKit Bug Importer 2018-11-21 07:42:29 PST 
<rdar://problem/46201523>