Bug 191869 - Merging an IC variant may lead to the IC status containing overlapping structure sets
Summary: Merging an IC variant may lead to the IC status containing overlapping struct...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-20 15:58 PST by Saam Barati
Modified: 2018-11-20 21:15 PST (History)
12 users (show)

See Also:

Attachments
patch (4.56 KB, patch)
2018-11-20 16:16 PST, Saam Barati 		mark.lam: review+
Details | Formatted Diff | Diff
patch for landing (4.52 KB, patch)
2018-11-20 20:36 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-11-20 15:58:57 PST 
We should check once we merge a variant that we haven't created a situation where more than two or more variants contain overlapping structure sets.
Comment 1 Saam Barati 2018-11-20 15:59:32 PST 
<rdar://problem/45403453>
Comment 2 Saam Barati 2018-11-20 16:16:47 PST 
Created attachment 355369 [details]
patch
Comment 3 Mark Lam 2018-11-20 16:57:22 PST 
Comment on attachment 355369 [details]
patch

r=me
Comment 4 Saam Barati 2018-11-20 20:36:45 PST 
Created attachment 355379 [details]
patch for landing
Comment 5 WebKit Commit Bot 2018-11-20 21:15:38 PST 
Comment on attachment 355379 [details]
patch for landing

Clearing flags on attachment: 355379

Committed r238411: <https://trac.webkit.org/changeset/238411>
Comment 6 WebKit Commit Bot 2018-11-20 21:15:40 PST 
All reviewed patches have been landed.  Closing bug.