The script parsing the *.messages.in files would treat a line starting with '#' as a comment, but not a line starting with '<whitespace>#'. This means that jamming a '#' right in front of the first character of a message definition (as opposed to the beginning of a line) will have no effect and the line will get treated just the same as a non-commented line. Fix this by trimming all white space from the beginning and ending of the line before processing it.
<rdar://problem/46189563>
Created attachment 355358 [details] Patch
Comment on attachment 355358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=355358&action=review r=me > Source/WebKit/Scripts/Makefile:8 > + grep FakeLoadURL webkit/*-expected.* && "### Test failure: found commented-out functions in output" || true I do not think we need this check here. Since you added comments to test-messages.in and webkit/MessageReceiver-expected.cpp did not change, it is validation enough.
Created attachment 355766 [details] Patch
Comment on attachment 355766 [details] Patch Clearing flags on attachment: 355766 Committed r238577: <https://trac.webkit.org/changeset/238577>
All reviewed patches have been landed. Closing bug.