Bug 191856 - Remove invalid assertion in VMTraps::SignalSender's SignalAction.
Summary: Remove invalid assertion in VMTraps::SignalSender's SignalAction.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-20 00:46 PST by Mark Lam
Modified: 2018-11-21 09:38 PST (History)
9 users (show)

See Also:

Attachments
proposed patch. (7.01 KB, patch)
2018-11-20 01:14 PST, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.44 MB, application/zip)
2018-11-20 03:32 PST, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-11-20 00:46:48 PST 
<rdar://problem/46089992>
Comment 1 Mark Lam 2018-11-20 01:14:22 PST 
Created attachment 355323 [details]
proposed patch.

Let's try this on the EWS.
Comment 2 EWS Watchlist 2018-11-20 03:32:56 PST 
Comment on attachment 355323 [details]
proposed patch.

Attachment 355323 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10086372

New failing tests:
media/no-fullscreen-when-hidden.html
Comment 3 EWS Watchlist 2018-11-20 03:32:57 PST 
Created attachment 355332 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 4 Mark Lam 2018-11-20 08:05:32 PST 
(In reply to Build Bot from comment #3)
> Created attachment 355332 [details]
> Archive of layout-test-results from ews125 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

I'm quite sure that the watchdog cannot affect this test.
Comment 5 Yusuke Suzuki 2018-11-21 00:22:43 PST 
Comment on attachment 355323 [details]
proposed patch.

r=me
Comment 6 Mark Lam 2018-11-21 09:38:32 PST 
Thanks for the review.  Landed in r238421: <http://trac.webkit.org/r238421>.