RESOLVED FIXED 191856
Remove invalid assertion in VMTraps::SignalSender's SignalAction. 
https://bugs.webkit.org/show_bug.cgi?id=191856
Summary Remove invalid assertion in VMTraps::SignalSender's SignalAction.
Mark Lam
Reported 2018-11-20 00:46:48 PST
<rdar://problem/46089992>
Attachments
proposed patch. (7.01 KB, patch)
2018-11-20 01:14 PST, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.44 MB, application/zip)
2018-11-20 03:32 PST, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-11-20 01:14:22 PST
Created attachment 355323 [details] proposed patch. Let's try this on the EWS.
EWS Watchlist
Comment 2 2018-11-20 03:32:56 PST
Comment on attachment 355323 [details] proposed patch. Attachment 355323 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10086372 New failing tests: media/no-fullscreen-when-hidden.html
EWS Watchlist
Comment 3 2018-11-20 03:32:57 PST
Created attachment 355332 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Mark Lam
Comment 4 2018-11-20 08:05:32 PST
(In reply to Build Bot from comment #3) > Created attachment 355332 [details] > Archive of layout-test-results from ews125 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6 I'm quite sure that the watchdog cannot affect this test.
Yusuke Suzuki
Comment 5 2018-11-21 00:22:43 PST
Comment on attachment 355323 [details] proposed patch. r=me
Mark Lam
Comment 6 2018-11-21 09:38:32 PST
Thanks for the review. Landed in r238421: <http://trac.webkit.org/r238421>.
Note You need to log in before you can comment on or make changes to this bug.