Bug 191851 - Document::focusNavigationStartingNode doesn't take shadow tree into account
Summary: Document::focusNavigationStartingNode doesn't take shadow tree into account
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2018-11-19 22:16 PST by Ryosuke Niwa
Modified: 2018-11-20 06:13 PST (History)
5 users (show)

See Also:


Attachments
A patch to add a test case (2.09 KB, patch)
2018-11-19 22:21 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-11-19 22:16:41 PST
Document::focusNavigationStartingNode needs to take shadow tree and slotted content into account.

This is a bit tricky because this code needs to traverse the composed tree forward & backward.
Comment 1 Ryosuke Niwa 2018-11-19 22:18:10 PST
Antti, what do you think about adding the support for traversing backwards to ElementAndTextDescendantIterator and ComposedTreeIterator?
Comment 2 Radar WebKit Bug Importer 2018-11-19 22:18:41 PST
<rdar://problem/46178587>
Comment 3 Ryosuke Niwa 2018-11-19 22:21:42 PST
Created attachment 355311 [details]
A patch to add a test case
Comment 4 Antti Koivisto 2018-11-20 06:13:42 PST
(In reply to Ryosuke Niwa from comment #1)
> Antti, what do you think about adding the support for traversing backwards
> to ElementAndTextDescendantIterator and ComposedTreeIterator?

Good idea!