Bug 191844 – Insert <attachment> elements under editable images to make their backing data accessible

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Insert <attachment> elements under editable images to make their backing data accessible

[Tim Horton]

<rdar://problem/30900149>

[Tim Horton]

Created attachment 355297 [details]
WIP

[Tim Horton]

Gonna try to write a test.

[EWS Watchlist]

Attachment 355297 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:493:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:494:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:495:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 3 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 355463 [details]
Patch

[EWS Watchlist]

Attachment 355463 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:493:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:494:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:495:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 3 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Wenson Hsieh]

Comment on attachment 355463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355463&action=review

The attachment-related changes look good to me!

> Source/WebCore/ChangeLog:38
> +        Store the aformentioned bits of information when cloned so that we can

Nit - aforementioned?

> Source/WebKit/UIProcess/API/APIAttachment.h:97
> +    mutable RetainPtr<NSFileWrapper> m_fileWrapper;

I think m_fileWrapper and m_fileWrapperGenerator should both be under PLATFORM(COCOA), or both be present everywhere.

> Source/WebKit/UIProcess/API/Cocoa/APIAttachmentCocoa.mm:194
> +    m_fileWrapperGenerator = WTFMove(fileWrapperGenerator);

Should we also invalidateGeneratedFileWrapper here?

> Source/WebKit/UIProcess/ios/EditableImageController.mm:51
> +    if (auto webPageProxy = m_webPageProxy.get())

Nit - auto*?

[Tim Horton]

Created attachment 355572 [details]
Patch

[EWS Watchlist]

Attachment 355572 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:493:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:494:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:495:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 3 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 355572 [details]
Patch

Attachment 355572 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10135973

New failing tests:
imported/w3c/web-platform-tests/webrtc/simplecall-no-ssrcs.https.html

[EWS Watchlist]

Created attachment 355579 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Tim Horton]

Comment on attachment 355579 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

Crashing test definitely does not appear to be relevant

[Tim Horton]

Created attachment 355584 [details]
Patch

[EWS Watchlist]

Attachment 355584 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:493:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:494:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:495:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 3 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Created attachment 355626 [details]
Patch

[EWS Watchlist]

Attachment 355626 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:493:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:494:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:495:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 3 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 355626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355626&action=review

> Source/WebCore/html/HTMLImageElement.cpp:337
> +        updateEditableImage(true);

Don't much like the boolean argument.

[Tim Horton]

Created attachment 355695 [details]
Patch

[EWS Watchlist]

Attachment 355695 [details] did not pass style-queue:


ERROR: Source/WebCore/page/ChromeClient.h:493:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:494:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/ChromeClient.h:495:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 3 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 355695 [details]
Patch

Clearing flags on attachment: 355695

Committed r238538: <https://trac.webkit.org/changeset/238538>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.