Bug 191832 - [GTK][WPE] Solve some issues in the enumerateDevices code
Summary: [GTK][WPE] Solve some issues in the enumerateDevices code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-19 03:39 PST by Alejandro G. Castro
Modified: 2018-11-19 05:17 PST (History)
8 users (show)

See Also:

Attachments
Patch (12.31 KB, patch)
2018-11-19 03:47 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Patch for landing (12.92 KB, patch)
2018-11-19 04:38 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2018-11-19 03:39:33 PST 
Address the issues pointed out here: https://bugs.webkit.org/show_bug.cgi?id=185761#c69
Comment 1 Alejandro G. Castro 2018-11-19 03:47:30 PST 
Created attachment 355263 [details]
Patch
Comment 2 EWS Watchlist 2018-11-19 03:49:11 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2018-11-19 04:13:50 PST 
Comment on attachment 355263 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355263&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebsiteData.h:52
> - * Since: 2.16
> + * Since: 2.24

This was correct. You need to add the since tag after the new item added to the enum.

> Source/WebKit/UIProcess/API/wpe/WebKitWebsiteData.h:52
> - * Since: 2.16
> + * Since: 2.24

Ditto.
Comment 4 Alejandro G. Castro 2018-11-19 04:38:09 PST 
Created attachment 355266 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-19 05:16:22 PST 
Comment on attachment 355266 [details]
Patch for landing

Clearing flags on attachment: 355266

Committed r238372: <https://trac.webkit.org/changeset/238372>
Comment 6 WebKit Commit Bot 2018-11-19 05:16:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-19 05:17:26 PST 
<rdar://problem/46167455>