Bug 191831 - [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
Summary: [CMake] Remove ENABLE_ACCESSIBILITY CMake variable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-19 02:03 PST by Fujii Hironori
Modified: 2019-07-09 18:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.26 KB, patch)
2018-11-25 20:11 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-11-19 02:03:17 PST 
[CMake] Remove ENABLE_ACCESSIBILITY CMake variable

It is confusing with HAVE_ACCESSIBILITY macro.

It is used only in WebKitTestRunner.
https://github.com/WebKit/webkit/blob/dea6e0141a5df7b678221d4a474b5846176a913d/Tools/WebKitTestRunner/CMakeLists.txt#L76

All CMake ports except AppleWin set ENABLE_ACCESSIBILITY=1.

Only AppleWin port set ENABLE_ACCESSIBILITY=0, but it doesn't
build WebKitTestRunner. If AppleWin port will use
WebKitTestRunner in the future, it will set
ENABLE_ACCESSIBILITY=1 because AppleWin port also defines
HAVE_ACCESSIBILITY=1.

[webkit-dev] Remove HAVE_ACCESSIBILITY
https://lists.webkit.org/pipermail/webkit-dev/2018-November/030251.html
Comment 1 Fujii Hironori 2018-11-25 20:11:43 PST 
Created attachment 355615 [details]
Patch
Comment 2 Fujii Hironori 2018-11-26 17:55:52 PST 
Comment on attachment 355615 [details]
Patch

Clearing flags on attachment: 355615

Committed r238539: <https://trac.webkit.org/changeset/238539>
Comment 3 Fujii Hironori 2018-11-26 17:55:55 PST 
All reviewed patches have been landed.  Closing bug.