RESOLVED FIXED 191830
Disable tests on systems without WebAssembly enabled 
https://bugs.webkit.org/show_bug.cgi?id=191830
Summary Disable tests on systems without WebAssembly enabled
Dominik Inführ
Reported 2018-11-19 01:27:06 PST
Disable tests on systems without WebAssembly enabled
Attachments
Patch (3.09 KB, patch)
2018-11-19 01:30 PST, Dominik Inführ 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominik Inführ
Comment 1 2018-11-19 01:30:40 PST
Created attachment 355259 [details] Patch
Mark Lam
Comment 2 2018-11-19 11:23:48 PST
Dominik, if the issue has already been fixed, you should: 1. include the URL of the revision that fixed the issue. In this case, that would be: https://trac.webkit.org/changeset/238373/webkit 2. Clear the flags on your patch so that they don't stay at r? and cq?. For tests that relies on wasm like this, the better fix is to put them in the JSTests/wasm/stress/ or JSTests/wasm/regress/ directories instead. You don't need an isWebAssemblyEnabled flag. Guillaume's fix is certainly still valid to indicate that the test is memory hungry.
Mark Lam
Comment 3 2018-11-19 11:24:28 PST
Comment on attachment 355259 [details] Patch Clearing flags to get this patch out of the review queue.
Radar WebKit Bug Importer
Comment 4 2018-11-19 11:25:23 PST
<rdar://problem/46171612>
Dominik Inführ
Comment 5 2018-11-20 00:56:38 PST
Thanks, will certainly do that the next time!
Note You need to log in before you can comment on or make changes to this bug.