Bug 191821 - Composited and tiled layers fail to update on scrolling in WebView
Summary: Composited and tiled layers fail to update on scrolling in WebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-17 20:54 PST by Simon Fraser (smfr)
Modified: 2018-11-27 13:57 PST (History)
5 users (show)

See Also:


Attachments
Patch (12.49 KB, patch)
2018-11-17 21:06 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.48 MB, application/zip)
2018-11-17 23:11 PST, EWS Watchlist
no flags Details
Patch (16.66 KB, patch)
2018-11-27 12:28 PST, Simon Fraser (smfr)
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-11-17 20:54:48 PST
Composited and tiled layers fail to update on scrolling in WebView
Comment 1 Simon Fraser (smfr) 2018-11-17 21:06:15 PST
Created attachment 355227 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-11-17 21:06:40 PST
<rdar://problem/46009272>
Comment 3 EWS Watchlist 2018-11-17 23:11:32 PST
Comment on attachment 355227 [details]
Patch

Attachment 355227 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10053576

New failing tests:
compositing/backing/backing-store-attachment-scroll.html
compositing/tiling/tile-coverage-on-scroll.html
Comment 4 EWS Watchlist 2018-11-17 23:11:34 PST
Created attachment 355230 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 Simon Fraser (smfr) 2018-11-27 12:28:21 PST
Created attachment 355761 [details]
Patch
Comment 6 zalan 2018-11-27 12:39:35 PST
Comment on attachment 355761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355761&action=review

> Source/WebCore/page/FrameView.cpp:2468
> +    if (RenderView* renderView = this->renderView()) {

auto pls.
Comment 7 Simon Fraser (smfr) 2018-11-27 13:57:41 PST
https://trac.webkit.org/changeset/238575/webkit