Bug 191810 - Clarify RenderLayerCompositor::hasAnyAdditionalCompositedLayers() and related code.
Summary: Clarify RenderLayerCompositor::hasAnyAdditionalCompositedLayers() and related...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-17 14:03 PST by Simon Fraser (smfr)
Modified: 2018-11-17 16:53 PST (History)
3 users (show)

See Also:

Attachments
Patch (8.47 KB, patch)
2018-11-17 14:03 PST, Simon Fraser (smfr) 		zalan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-11-17 14:03:12 PST 
Clarify RenderLayerCompositor::hasAnyAdditionalCompositedLayers() and related code.
Comment 1 Simon Fraser (smfr) 2018-11-17 14:03:40 PST 
Created attachment 355202 [details]
Patch
Comment 2 zalan 2018-11-17 14:08:08 PST 
Comment on attachment 355202 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355202&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1257
> +    if (&layer != m_renderView.layer()) {
> +        ASSERT(m_contentLayersCount > 0);
> +        --m_contentLayersCount;
> +    }

Don't we prefer the early return style?
if (&layer == m_renderView.layer())
    return;
Comment 4 Radar WebKit Bug Importer 2018-11-17 16:53:33 PST 
<rdar://problem/46152495>