Bug 191801 - [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
Summary: [LFC][IFC] InlineFormattingState::addDetachingRule should accumulate rules.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Keywords: InRadar
Depends on:
Reported: 2018-11-16 21:17 PST by zalan
Modified: 2018-11-17 08:12 PST (History)
6 users (show)

See Also:

Patch (8.22 KB, patch)
2018-11-16 21:46 PST, zalan
koivisto: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews203 for win-future (12.80 MB, application/zip)
2018-11-17 00:57 PST, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-11-16 21:17:11 PST
instead of overwriting the old ones.
Comment 1 zalan 2018-11-16 21:46:29 PST
Created attachment 355180 [details]
Comment 2 EWS Watchlist 2018-11-17 00:57:45 PST
Comment on attachment 355180 [details]

Attachment 355180 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10031591

New failing tests:
Comment 3 EWS Watchlist 2018-11-17 00:57:56 PST
Created attachment 355190 [details]
Archive of layout-test-results from ews203 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Antti Koivisto 2018-11-17 06:57:08 PST
Comment on attachment 355180 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=355180&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingState.cpp:58
> +    auto result = m_detachingRules.add(&layoutBox, detachingRule);
> +    if (result.isNewEntry)
> +        return;
> +    result.iterator->value.add(detachingRule);

m_detachingRules.add(&layoutBox, { }).iterator->value.add(detachingRule);

is probably equivalent and bit more compact?

> Source/WebCore/layout/inlineformatting/InlineFormattingState.h:77
> +    void setDetachingRules(const Box& layoutBox, DetachingRules detachingRules) { m_detachingRules.set(&layoutBox, detachingRules); }

Not from this patch but most OptionSet sites don't have type alias but simply write out the whole thing. 'OptionSet<DetachingRule>' is a less mysterious type than 'DetachingRules'.
Comment 5 zalan 2018-11-17 08:11:31 PST
Committed r238349: <https://trac.webkit.org/changeset/238349>
Comment 6 Radar WebKit Bug Importer 2018-11-17 08:12:36 PST