Bug 191794 – [WebGPU] Begin implementing WebGPUTexture, WebGPUTextureView, and WebGPUTextureFormatEnum, and WebGPUSwapChain::configure upgrades

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Justin Fan]

[WebGPU] Begin implementing WebGPUTexture, WebGPUTextureView, and WebGPUTextureFormatEnum, and WebGPUSwapChain::configure upgrades

[Justin Fan]

Created attachment 355163 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/46144874>

[Dean Jackson]

Comment on attachment 355163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355163&action=review

> Source/WebCore/Modules/webgpu/GPUTextureFormatEnum.h:40
> +std::optional<PlatformTextureFormat> convertAndValidate(GPUTextureFormatEnum);

I'm not sure I like this in the WebCore namespace. Do we need it in more than one place? i.e. can it be file static?

It seems it is only used in GPUSwapChainMetal, so I think it can live there for the moment.

> Source/WebCore/Modules/webgpu/WebGPUTextureFormatEnum.idl:33
> +    "R8G8B8A8Unorm",
> +    "R8G8B8A8Uint",
> +    "B8G8R8A8Unorm",
> +    "D32FloatS8Uint"

Ugh. I wonder if WebGPU should use better names here. Or maybe those are the names everyone expects?

[Dean Jackson]

I might make the small changes and land this patch.

[Jon Lee]

Comment on attachment 355163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355163&action=review

>> Source/WebCore/Modules/webgpu/WebGPUTextureFormatEnum.idl:33
>> +    "D32FloatS8Uint"
> 
> Ugh. I wonder if WebGPU should use better names here. Or maybe those are the names everyone expects?

I think so.
https://docs.rs/vulkano/0.7/vulkano/format/index.html
https://docs.microsoft.com/en-us/windows/desktop/api/dxgiformat/ne-dxgiformat-dxgi_format

[Dean Jackson]

Committed r238382: <https://trac.webkit.org/changeset/238382>

[Dean Jackson]

(In reply to Jon Lee from comment #5)
> Comment on attachment 355163 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=355163&action=review
> 
> >> Source/WebCore/Modules/webgpu/WebGPUTextureFormatEnum.idl:33
> >> +    "D32FloatS8Uint"
> > 
> > Ugh. I wonder if WebGPU should use better names here. Or maybe those are the names everyone expects?
> 
> I think so.
> https://docs.rs/vulkano/0.7/vulkano/format/index.html
> https://docs.microsoft.com/en-us/windows/desktop/api/dxgiformat/ne-
> dxgiformat-dxgi_format

OK! Metal seems to make them a little nicer, in that R8G8B8A8 -> RGBA8, but I guess it doesn't matter.