RESOLVED FIXED 191790
[ews-app] Set Foreign Keys in EWS Django app models 
https://bugs.webkit.org/show_bug.cgi?id=191790
Summary [ews-app] Set Foreign Keys in EWS Django app models
Aakash Jain
Reported 2018-11-16 16:22:40 PST
Fix TODO for configuring Foreign Keys in EWS Django app models.
Attachments
Proposed patch (2.23 KB, patch)
2018-11-16 16:24 PST, Aakash Jain 		lforschler: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2018-11-16 16:24:08 PST
Created attachment 355157 [details] Proposed patch
Kocsen Chung
Comment 2 2018-11-16 16:53:26 PST
Comment on attachment 355157 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355157&action=review > Tools/BuildSlaveSupport/ews-app/ews/models/steps.py:-30 > - buildid = models.IntegerField() # TODO: set foreign key Nit: May be too late now but if should we make it `build_id` instead of `buildid`.
Aakash Jain
Comment 3 2018-11-24 05:22:10 PST
Comment on attachment 355157 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=355157&action=review >> Tools/BuildSlaveSupport/ews-app/ews/models/steps.py:-30 >> - buildid = models.IntegerField() # TODO: set foreign key > > Nit: May be too late now but if should we make it `build_id` instead of `buildid`. This patch already deleted buildid variable, and adds 'build'. Django internally seems to convert build to build_id as it is used as a ForeignKey.
Aakash Jain
Comment 4 2018-11-26 13:45:11 PST
Committed r238518: <https://trac.webkit.org/changeset/238518>
Radar WebKit Bug Importer
Comment 5 2018-11-26 13:46:31 PST
<rdar://problem/46255319>
Note You need to log in before you can comment on or make changes to this bug.