Bug 191790 - [ews-app] Set Foreign Keys in EWS Django app models
Summary: [ews-app] Set Foreign Keys in EWS Django app models
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-16 16:22 PST by Aakash Jain
Modified: 2019-02-14 13:27 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (2.23 KB, patch)
2018-11-16 16:24 PST, Aakash Jain 		lforschler: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-11-16 16:22:40 PST 
Fix TODO for configuring Foreign Keys in EWS Django app models.
Comment 1 Aakash Jain 2018-11-16 16:24:08 PST 
Created attachment 355157 [details]
Proposed patch
Comment 2 Kocsen Chung 2018-11-16 16:53:26 PST 
Comment on attachment 355157 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355157&action=review

> Tools/BuildSlaveSupport/ews-app/ews/models/steps.py:-30
> -    buildid = models.IntegerField()  # TODO: set foreign key

Nit: May be too late now but if should we make it `build_id` instead of `buildid`.
Comment 3 Aakash Jain 2018-11-24 05:22:10 PST 
Comment on attachment 355157 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355157&action=review

>> Tools/BuildSlaveSupport/ews-app/ews/models/steps.py:-30
>> -    buildid = models.IntegerField()  # TODO: set foreign key
> 
> Nit: May be too late now but if should we make it `build_id` instead of `buildid`.

This patch already deleted buildid variable, and adds 'build'. Django internally seems to convert build to build_id as it is used as a ForeignKey.
Comment 4 Aakash Jain 2018-11-26 13:45:11 PST 
Committed r238518: <https://trac.webkit.org/changeset/238518>
Comment 5 Radar WebKit Bug Importer 2018-11-26 13:46:31 PST 
<rdar://problem/46255319>