Bug 191778 - Optimize composited iframe layer hookup
Summary: Optimize composited iframe layer hookup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-16 14:52 PST by Simon Fraser (smfr)
Modified: 2018-11-17 12:51 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.73 KB, patch)
2018-11-16 14:54 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-11-16 14:52:48 PST
Optimize composited iframe layer hookup
Comment 1 Simon Fraser (smfr) 2018-11-16 14:54:15 PST
Created attachment 355132 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-11-16 14:55:02 PST
Also made the paint layer dumping show some renderer info, making them easier to identify.
Comment 3 WebKit Commit Bot 2018-11-16 19:06:30 PST
Comment on attachment 355132 [details]
Patch

Clearing flags on attachment: 355132

Committed r238337: <https://trac.webkit.org/changeset/238337>
Comment 4 WebKit Commit Bot 2018-11-16 19:06:31 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-16 19:07:25 PST
<rdar://problem/46146331>
Comment 6 Chris Dumez 2018-11-16 20:37:14 PST
Can this have caused these failures?
https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r238338%20(1072)/results.html
Comment 7 Simon Fraser (smfr) 2018-11-17 12:51:07 PST
(In reply to Chris Dumez from comment #6)
> Can this have caused these failures?
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/
> r238338%20(1072)/results.html

No, I think those are all the Mojave WindowServer bug that causes WK1 snapshots to be blank or cyan sometimes.