Bug 191769 – webkitpy: Retry app installation on watchOS simulators

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

It takes a few seconds for apps to be installable on freshly booted watchOS simulators.

[Jonathan Bedard]

Created attachment 355115 [details]
Patch

[Aakash Jain]

Comment on attachment 355115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355115&action=review

r=me after the changes.

> Tools/Scripts/webkitpy/xcode/simulated_device.py:548
> +        for i in xrange(3):

Please move 3 to a variable. e.g.: NUM_RETRIES_FOR_WATCH_INSTALL

> Tools/Scripts/webkitpy/xcode/simulated_device.py:552
> +            if exit_code != 204:

what does 204 indicate? maybe worth adding a comment.

> Tools/Scripts/webkitpy/xcode/simulated_device.py:553
> +                break

why break instead of return?

[Jonathan Bedard]

Created attachment 355120 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/46139850>

[Aakash Jain]

Comment on attachment 355120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355120&action=review

> Tools/Scripts/webkitpy/xcode/simulated_device.py:553
> +            # Return code indicates that the devices is booting and a retry may be successful.

This is confusing. Which return code indicates device is booting?

If 204 indicates booting, then it might be simpler/more-readable to check for 204. something like:

elif exit_code == 204:
    # Return code 204 indicates that the devices is booting. Retry after 5s.
    time.sleep(5)
else:
    return False

return False

[Jonathan Bedard]

Created attachment 355128 [details]
Patch

[Jonathan Bedard]

Created attachment 355139 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 355139 [details]
Patch

Clearing flags on attachment: 355139

Committed r238319: <https://trac.webkit.org/changeset/238319>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 355658 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 355658 [details]
Patch

Clearing flags on attachment: 355658

Committed r238514: <https://trac.webkit.org/changeset/238514>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.