WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
191760
Add html{color:text} to the simpleUserAgentStyleSheet on macOS
https://bugs.webkit.org/show_bug.cgi?id=191760
Summary
Add html{color:text} to the simpleUserAgentStyleSheet on macOS
Timothy Hatcher
Reported
2018-11-16 11:10:09 PST
Forgot to add it in
https://trac.webkit.org/changeset/238212/webkit
for
bug 191607
.
Attachments
Patch
(2.01 KB, patch)
2018-11-16 11:20 PST
,
Timothy Hatcher
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Timothy Hatcher
Comment 1
2018-11-16 11:20:22 PST
Created
attachment 355079
[details]
Patch
Antti Koivisto
Comment 2
2018-11-16 11:29:53 PST
Comment on
attachment 355079
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=355079&action=review
> Source/WebCore/css/CSSDefaultStyleSheets.cpp:84 > +// The only difference in the simple style sheet for macOS is the addition of html{color:text}.
You could use macros to reduce copy-paste. Not sure if that is much better.
Simon Fraser (smfr)
Comment 3
2018-11-16 11:30:48 PST
Comment on
attachment 355079
[details]
Patch How can this be tested?
WebKit Commit Bot
Comment 4
2018-11-16 12:13:33 PST
Comment on
attachment 355079
[details]
Patch Clearing flags on attachment: 355079 Committed
r238295
: <
https://trac.webkit.org/changeset/238295
>
WebKit Commit Bot
Comment 5
2018-11-16 12:13:35 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6
2018-11-16 14:36:50 PST
<
rdar://problem/46140104
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug