Bug 191760 - Add html{color:text} to the simpleUserAgentStyleSheet on macOS
Summary: Add html{color:text} to the simpleUserAgentStyleSheet on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-16 11:10 PST by Timothy Hatcher
Modified: 2018-11-16 14:36 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2018-11-16 11:20 PST, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-11-16 11:10:09 PST 
Forgot to add it in https://trac.webkit.org/changeset/238212/webkit for bug 191607.
Comment 1 Timothy Hatcher 2018-11-16 11:20:22 PST 
Created attachment 355079 [details]
Patch
Comment 2 Antti Koivisto 2018-11-16 11:29:53 PST 
Comment on attachment 355079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355079&action=review

> Source/WebCore/css/CSSDefaultStyleSheets.cpp:84
> +// The only difference in the simple style sheet for macOS is the addition of html{color:text}.

You could use macros to reduce copy-paste. Not sure if that is much better.
Comment 3 Simon Fraser (smfr) 2018-11-16 11:30:48 PST 
Comment on attachment 355079 [details]
Patch

How can this be tested?
Comment 4 WebKit Commit Bot 2018-11-16 12:13:33 PST 
Comment on attachment 355079 [details]
Patch

Clearing flags on attachment: 355079

Committed r238295: <https://trac.webkit.org/changeset/238295>
Comment 5 WebKit Commit Bot 2018-11-16 12:13:35 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-16 14:36:50 PST 
<rdar://problem/46140104>