Bug 191758 – Web Inspector: Audit: add default tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

We should create some default tests so that the initial Audit tab isn't empty.

[Devin Rousso]

Created attachment 355075 [details]
Patch

I'd like to add another default test, so this is not committable yet.  It is reviewable tho :)

[Matt Baker]

Comment on attachment 355075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355075&action=review

r=me

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:85
> +localizedStrings["Add default audits"] = "Add default audits";

Push button text should use title case: "Add Default Audits".

[Matt Baker]

Since this just adds the accessibility audit, the name of the bug should probably be retitled.

[Devin Rousso]

(In reply to Matt Baker from comment #3)
> Since this just adds the accessibility audit, the name of the bug should
> probably be retitled.
I’m planning on adding another audit later today (reuploading a new patch).

[Devin Rousso]

Created attachment 355165 [details]
Patch

Any feedback on the default audits I've written would be greatly appreciated :)

[Devin Rousso]

Created attachment 355167 [details]
Patch

Use template strings for audit test names and functions

[WebKit Commit Bot]

Comment on attachment 355167 [details]
Patch

Clearing flags on attachment: 355167

Committed r238334: <https://trac.webkit.org/changeset/238334>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46145781>