Bug 191752 - [Pointer Events] event.isPrimary doesn't always represent the oldest active touch
Summary: [Pointer Events] event.isPrimary doesn't always represent the oldest active t...
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
Depends on:
Reported: 2018-11-16 09:30 PST by Antoine Quint
Modified: 2018-11-17 01:30 PST (History)
7 users (show)

See Also:

Patch (12.77 KB, patch)
2018-11-16 09:46 PST, Antoine Quint
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-11-16 09:30:40 PST
Our current support of pointer events for touch devices doesn't always represent the oldest active touch.
Comment 1 Radar WebKit Bug Importer 2018-11-16 09:31:54 PST
Comment 2 Antoine Quint 2018-11-16 09:46:51 PST
Created attachment 355068 [details]
Comment 3 EWS Watchlist 2018-11-16 09:49:43 PST
Attachment 355068 [details] did not pass style-queue:

ERROR: Source/WebCore/dom/PointerEvent.h:87:  The parameter name "isCancelable" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Dean Jackson 2018-11-16 09:52:41 PST
Comment on attachment 355068 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=355068&action=review

> LayoutTests/pointerevents/ios/pointer-events-is-primary.html:18
> +function dumpEvent(event)
> +{
> +    console.log(`[${event.pointerId} ${event.type}] x = ${event.clientX}, y = ${event.clientY}, isPrimary = ${event.isPrimary}`);
> +}

This function is never used.
Comment 5 Antoine Quint 2018-11-17 01:30:02 PST
Committed r238344: <https://trac.webkit.org/changeset/238344>