Bug 191751 – Prevent recursion while creating media controls

• Status: ASSIGNED
• Component: Media

[Eric Carlson]

Modern Media Controls calls getComputedStyle from its constructor, which can fire events and allow scripts to call back into the media element.

[Eric Carlson]

Created attachment 355094 [details]
Patch

[EWS Watchlist]

Comment on attachment 355094 [details]
Patch

Attachment 355094 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10022206

New failing tests:
media/modern-media-controls/css/transformed-media.html
fast/canvas/webgl/texImage2D-video-flipY-true.html
media/video-load-preload-none.html
security/contentSecurityPolicy/blocks-video.html
fast/canvas/webgl/texImage2D-video-flipY-false.html
media/video-restricted-no-preload-metadata.html
media/media-blocked-by-beforeload.html

[EWS Watchlist]

Created attachment 355108 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355094 [details]
Patch

Attachment 355094 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10022213

New failing tests:
media/modern-media-controls/css/transformed-media.html
fast/canvas/webgl/texImage2D-video-flipY-true.html
media/video-load-preload-none.html
security/contentSecurityPolicy/blocks-video.html
fast/canvas/webgl/texImage2D-video-flipY-false.html
media/video-restricted-no-preload-metadata.html
media/media-blocked-by-beforeload.html

[EWS Watchlist]

Created attachment 355110 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355094 [details]
Patch

Attachment 355094 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10022159

New failing tests:
fast/canvas/webgl/texImage2D-video-flipY-true.html
media/video-load-preload-none.html
security/contentSecurityPolicy/blocks-video.html
fast/canvas/webgl/texImage2D-video-flipY-false.html
media/video-restricted-no-preload-metadata.html
media/media-blocked-by-beforeload.html

[EWS Watchlist]

Created attachment 355113 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355094 [details]
Patch

Attachment 355094 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10022534

New failing tests:
media/modern-media-controls/media-controller/media-controller-resize.html
media/modern-media-controls/css/transformed-media.html
media/video-load-preload-none.html
media/controls-without-preload.html
security/contentSecurityPolicy/blocks-video.html
media/video-restricted-no-preload-metadata.html
media/media-blocked-by-beforeload.html

[EWS Watchlist]

Created attachment 355129 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 355094 [details]
Patch

Attachment 355094 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/10023503

New failing tests:
security/contentSecurityPolicy/blocks-video.html

[EWS Watchlist]

Created attachment 355137 [details]
Archive of layout-test-results from ews203 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews203  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Eric Carlson]

<rdar://problem/46018918>

[Eric Carlson]

Created attachment 355742 [details]
Patch

[Dean Jackson]

Comment on attachment 355742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355742&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:121
> +        window.requestAnimationFrame(() => this._updateControlsSize());

You don't need the "window." part.

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:202
> +                window.requestAnimationFrame(() => this._updateControlsSize());

or here.

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:230
> +            window.requestAnimationFrame(() => this._updateControlsSize());

or here.

[EWS Watchlist]

Comment on attachment 355742 [details]
Patch

Attachment 355742 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10168935

New failing tests:
media/modern-media-controls/css/transformed-media.html
media/modern-media-controls/media-controller/media-controller-resize.html

[EWS Watchlist]

Created attachment 355751 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Ahmad Saleem]

Just checked one function change and it seems this never landed in any shape or form.

Is this still relevant?