Bug 191741 – XMLHttpRequest has the wrong fallback encoding

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Anne van Kesteren]

See https://github.com/web-platform-tests/wpt/pull/14090.

[Rob Buis]

Created attachment 355397 [details]
Patch

[EWS Watchlist]

Comment on attachment 355397 [details]
Patch

Attachment 355397 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10097481

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 355398 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355397 [details]
Patch

Attachment 355397 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10097488

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 355399 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Rob Buis]

Created attachment 355400 [details]
Patch

[EWS Watchlist]

Comment on attachment 355400 [details]
Patch

Attachment 355400 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10098189

New failing tests:
imported/w3c/web-platform-tests/encoding/unsupported-encodings.html
imported/w3c/web-platform-tests/encoding/replacement-encodings.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.worker.html

[EWS Watchlist]

Created attachment 355401 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355400 [details]
Patch

Attachment 355400 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10098209

New failing tests:
imported/w3c/web-platform-tests/encoding/unsupported-encodings.html
imported/w3c/web-platform-tests/encoding/replacement-encodings.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.worker.html

[EWS Watchlist]

Created attachment 355402 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Rob Buis]

Created attachment 355408 [details]
Patch

[EWS Watchlist]

Comment on attachment 355408 [details]
Patch

Attachment 355408 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10099193

New failing tests:
imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.worker.html
swipe/pushState-cached-back-swipe.html

[EWS Watchlist]

Created attachment 355412 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355408 [details]
Patch

Attachment 355408 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10099263

New failing tests:
imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.worker.html

[EWS Watchlist]

Created attachment 355418 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Rob Buis]

Created attachment 355432 [details]
Patch

[EWS Watchlist]

Comment on attachment 355432 [details]
Patch

Attachment 355432 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10105882

New failing tests:
media/no-fullscreen-when-hidden.html

[EWS Watchlist]

Created attachment 355462 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Rob Buis]

Created attachment 362268 [details]
Patch

[Rob Buis]

Created attachment 367535 [details]
Patch

[Alex Christensen]

Comment on attachment 367535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367535&action=review

> LayoutTests/imported/w3c/ChangeLog:3
> +        XMLHttpRequest seemingly has the wrong fallback encoding

Remove seemingly.

> LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt:12
> +FAIL replacement - non-empty input decodes to one replacement character. assert_equals: Decoding with replacement expected "U+FFFD" but got "U+0041/U+0042/U+0043/U+0061/U+0062/U+0063/U+0031/U+0032/U+0033/U+FFFD"

What would it take too make this pass at the same time?  Does this pass in Chrome and Firefox?  I can't figure out how to run this test from http://w3c-test.org/encoding/

[Rob Buis]

Created attachment 367562 [details]
Patch

[Rob Buis]

Comment on attachment 367535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367535&action=review

>> LayoutTests/imported/w3c/ChangeLog:3
>> +        XMLHttpRequest seemingly has the wrong fallback encoding
> 
> Remove seemingly.

Right, that was a bit silly, done.

>> LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt:12
>> +FAIL replacement - non-empty input decodes to one replacement character. assert_equals: Decoding with replacement expected "U+FFFD" but got "U+0041/U+0042/U+0043/U+0061/U+0062/U+0063/U+0031/U+0032/U+0033/U+FFFD"
> 
> What would it take too make this pass at the same time?  Does this pass in Chrome and Firefox?  I can't figure out how to run this test from http://w3c-test.org/encoding/

Maybe you don't know this convenient site yet?:
https://wpt.fyi/results/encoding/replacement-encodings.any.html?label=master&product=chrome%5Bexperimental%5D&product=edge&product=firefox%5Bexperimental%5D&product=safari%5Bexperimental%5D&aligned
So yes it passes in Chrome and Firefox.
I have not looked at the FAIL before, unfortunately I am traveling until Thursday. IMHO this patch is an improvement in itself and I suspect the fix for above is not in XMLHttpRequest.cpp.

[WebKit Commit Bot]

Comment on attachment 367562 [details]
Patch

Clearing flags on attachment: 367562

Committed r244377: <https://trac.webkit.org/changeset/244377>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49972266>