Bug 191727 - Web Inspector: Audit: minor style improvements
Summary: Web Inspector: Audit: minor style improvements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: WebInspectorAuditTab
Blocks:
  Show dependency treegraph
 
Reported: 2018-11-15 17:18 PST by Devin Rousso
Modified: 2018-11-26 19:43 PST (History)
7 users (show)

See Also:


Attachments
Patch (12.43 KB, patch)
2018-11-15 17:22 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (12.61 KB, patch)
2018-11-15 17:25 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.54 MB, application/zip)
2018-11-15 18:19 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.01 MB, application/zip)
2018-11-15 18:36 PST, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-sierra (2.19 MB, application/zip)
2018-11-15 19:19 PST, EWS Watchlist
no flags Details
Patch (15.28 KB, patch)
2018-11-16 10:46 PST, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (15.28 KB, patch)
2018-11-16 17:21 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-11-15 17:18:52 PST
- horizontally align the right-side items
 - increase the horizontal space between test case result icon and title
 - change description color
 - clear test results on navigation
 - capture the CSS path when the test finishes, not on export

And possibly more :)
Comment 1 Devin Rousso 2018-11-15 17:22:32 PST
Created attachment 355001 [details]
Patch
Comment 2 Devin Rousso 2018-11-15 17:25:28 PST
Created attachment 355002 [details]
Patch
Comment 3 Devin Rousso 2018-11-15 17:26:14 PST
One thing I was also thinking about adding (but not sure of) is possibly some warning when viewing a saved result after navigation explaining that the DOM nodes shown (if any) aren't live anymore, and won't respond to any interactions.  Considering how we rehydrate DOM nodes when importing, maybe we should attempt to rehydrate when navigating as well, but only if the URL stays the same (it would change to show the CSS path otherwise).  Thoughts?
Comment 4 EWS Watchlist 2018-11-15 18:19:19 PST Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-11-15 18:19:20 PST Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-11-15 18:36:26 PST Comment hidden (obsolete)
Comment 7 EWS Watchlist 2018-11-15 18:36:27 PST Comment hidden (obsolete)
Comment 8 EWS Watchlist 2018-11-15 19:19:15 PST Comment hidden (obsolete)
Comment 9 EWS Watchlist 2018-11-15 19:19:16 PST Comment hidden (obsolete)
Comment 10 Devin Rousso 2018-11-16 10:46:20 PST
Created attachment 355077 [details]
Patch
Comment 11 Joseph Pecoraro 2018-11-16 17:18:17 PST
Comment on attachment 355077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355077&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:23
> +
> +

Style: extra newline.
Comment 12 Devin Rousso 2018-11-16 17:21:54 PST
Created attachment 355168 [details]
Patch
Comment 13 WebKit Commit Bot 2018-11-16 18:10:52 PST
Comment on attachment 355168 [details]
Patch

Clearing flags on attachment: 355168

Committed r238333: <https://trac.webkit.org/changeset/238333>
Comment 14 WebKit Commit Bot 2018-11-16 18:10:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-11-16 18:11:38 PST
<rdar://problem/46145710>