Bug 191727 – Web Inspector: Audit: minor style improvements

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

- horizontally align the right-side items
 - increase the horizontal space between test case result icon and title
 - change description color
 - clear test results on navigation
 - capture the CSS path when the test finishes, not on export

And possibly more :)

[Devin Rousso]

Created attachment 355001 [details]
Patch

[Devin Rousso]

Created attachment 355002 [details]
Patch

[Devin Rousso]

One thing I was also thinking about adding (but not sure of) is possibly some warning when viewing a saved result after navigation explaining that the DOM nodes shown (if any) aren't live anymore, and won't respond to any interactions.  Considering how we rehydrate DOM nodes when importing, maybe we should attempt to rehydrate when navigating as well, but only if the URL stays the same (it would change to show the CSS path otherwise).  Thoughts?

[EWS Watchlist]

Comment on attachment 355002 [details]
Patch

Attachment 355002 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/10010829

New failing tests:
inspector/audit/data-domNodes.html

[EWS Watchlist]

Created attachment 355009 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355002 [details]
Patch

Attachment 355002 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/10010967

New failing tests:
inspector/audit/data-domNodes.html

[EWS Watchlist]

Created attachment 355011 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 355002 [details]
Patch

Attachment 355002 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/10011134

New failing tests:
inspector/audit/data-domNodes.html

[EWS Watchlist]

Created attachment 355014 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Devin Rousso]

Created attachment 355077 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 355077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=355077&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:23
> +
> +

Style: extra newline.

[Devin Rousso]

Created attachment 355168 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 355168 [details]
Patch

Clearing flags on attachment: 355168

Committed r238333: <https://trac.webkit.org/changeset/238333>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46145710>