Bug 19171 – [GTK] GTypes for enumeration

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Marco Barisione]

WebKit doesn't have gobject types for enums, so they cannot be used as properties.

[Marco Barisione]

Created attachment 21273 [details]
Generate webkit-enum-types.h and .cpp

[Jan Alonzo]

*** Bug 16119 has been marked as a duplicate of this bug. ***

[Jan Alonzo]

Rather than using sed, is it better to use /*< underscore_name=foo >*/ in beside the enum decl?

[Eric Seidel (no email)]

Comment on attachment 21273 [details]
Generate webkit-enum-types.h and .cpp

Um.  I have no clue if this is right or not.  Looks sane to me, but someone from GTK land should review.

[Marco Barisione]

(In reply to comment #3)
> Rather than using sed, is it better to use /*< underscore_name=foo >*/ in
> beside the enum decl?

I didn't know of its existence and on #gnome-hackers everyone suggested to use sed. What I don't like of underscore_name is that you have to remember to put it everywhere and if you forget it you will probably realise the error only when someone will start using a WebKit enum type for a property.

What do you prefer: the clean and error prone way or the ugly but working one? ;)

[Jan Alonzo]

Working is good =)

[Marco Barisione]

Created attachment 21663 [details]
Generate webkit-enum-types.h and .cpp

Same patch but that doesn't break out-of-tree builds.

[Alp Toker]

Comment on attachment 21663 [details]
Generate webkit-enum-types.h and .cpp

Please keep an eye on the bot when landing this to avoid build breakage.

[Jan Alonzo]

Landed in r34646