Bug 191708 - WKPreferencesSetFontSmoothingLevel doesn't actually do anything
Summary: WKPreferencesSetFontSmoothingLevel doesn't actually do anything
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-15 13:42 PST by Myles C. Maxfield
Modified: 2018-11-15 17:56 PST (History)
4 users (show)

See Also:


Attachments
Patch (15.07 KB, patch)
2018-11-15 13:44 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2018-11-15 13:42:45 PST
WKPreferencesSetFontSmoothingLevel doesn't actually do anything
Comment 1 Myles C. Maxfield 2018-11-15 13:44:26 PST
Created attachment 354981 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-11-15 14:17:39 PST
Comment on attachment 354981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354981&action=review

> Source/WebKit/ChangeLog:8
> +        Delete the symbol because no one calls it and it doesn't do anything

It's called by TestController::resetPreferencesToConsistentValues() and turns off subpixel antialiasing on platforms that still support that.
Comment 3 Myles C. Maxfield 2018-11-15 17:02:58 PST
Comment on attachment 354981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354981&action=review

>> Source/WebKit/ChangeLog:8
>> +        Delete the symbol because no one calls it and it doesn't do anything
> 
> It's called by TestController::resetPreferencesToConsistentValues() and turns off subpixel antialiasing on platforms that still support that.

It is called, but this call doesn't do anything. Smoothing is controlled by another mechanism instead.
Comment 4 Myles C. Maxfield 2018-11-15 17:24:21 PST
Comment on attachment 354981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354981&action=review

>>> Source/WebKit/ChangeLog:8
>>> +        Delete the symbol because no one calls it and it doesn't do anything
>> 
>> It's called by TestController::resetPreferencesToConsistentValues() and turns off subpixel antialiasing on platforms that still support that.
> 
> It is called, but this call doesn't do anything. Smoothing is controlled by another mechanism instead.

It's controlled by WKContextSetShouldUseFontSmoothing()
Comment 5 WebKit Commit Bot 2018-11-15 17:55:11 PST
Comment on attachment 354981 [details]
Patch

Clearing flags on attachment: 354981

Committed r238264: <https://trac.webkit.org/changeset/238264>
Comment 6 WebKit Commit Bot 2018-11-15 17:55:13 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-15 17:56:26 PST
<rdar://problem/46114818>