Bug 191705 - Increase EWS lock timeout to 3 hours
Summary: Increase EWS lock timeout to 3 hours
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-15 13:17 PST by Aakash Jain
Modified: 2018-11-16 14:20 PST (History)
6 users (show)

See Also:


Attachments
Proposed patch (1.15 KB, patch)
2018-11-15 13:20 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Proposed patch (1.15 KB, patch)
2018-11-15 13:22 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2018-11-15 13:17:31 PST
We should increase the EWS lock timeout for a patch from 2 hours to 3 hours.

Many times 2 hours is not enough for the patch to be completely processed, especially in case of test failure and retries.

e.g.: In https://webkit-queues.webkit.org/patch/354938/ios-sim-ews ews121 was still processing the patch for 2+ hours, when EWS unlocked the patch, and ews125 also started processing same patch.
Comment 1 Aakash Jain 2018-11-15 13:20:02 PST
Created attachment 354977 [details]
Proposed patch
Comment 2 Aakash Jain 2018-11-15 13:22:06 PST
Created attachment 354979 [details]
Proposed patch
Comment 3 WebKit Commit Bot 2018-11-15 14:05:35 PST
Comment on attachment 354979 [details]
Proposed patch

Clearing flags on attachment: 354979

Committed r238251: <https://trac.webkit.org/changeset/238251>
Comment 4 WebKit Commit Bot 2018-11-15 14:05:37 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-15 14:06:34 PST
<rdar://problem/46107448>
Comment 6 Aakash Jain 2018-11-15 14:06:49 PST
Will deploy to webkit-queues soon.
Comment 7 Aakash Jain 2018-11-16 14:20:35 PST
This change has been deployed to webkit-quues.