Bug 191701 – [Win] Reduce the use of WKSI library calls: Font Handling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brent Fulgham]

Move some ancient font handling code out of WKSI and into Open Source as a first step in moving away from the GDI font implementation.

[Radar WebKit Bug Importer]

<rdar://problem/46104809>

[Brent Fulgham]

This is step one in a migration away from WKSI in general, and for CG Font handling. Future patches will convert to new font handling routines.

[Brent Fulgham]

Created attachment 354976 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 354976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354976&action=review

r=me assuming the big green block is just copied/pasted from WKSI

> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:1141
> +        flush();

This seems unrelated...

> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:1164
> +    flush();

Ditto.

> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:1194
> +    flush();

Ditto.

> Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp:151
> -    wkGetGlyphAdvances(font, m, m_platformData.isSystemFont(), isPrinterFont, glyph, advance);
> +    FontCascade::getGlyphAdvances(font, m, m_platformData.isSystemFont(), isPrinterFont, glyph, advance);

We have similarly named functions; I'd prefer putting the word "platform" inside the name of this function somewhere.

[Brent Fulgham]

Comment on attachment 354976 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354976&action=review

>> Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp:1141
>> +        flush();
> 
> This seems unrelated...

Oh, yeah. I was fixing some canvas tests. I'll back that part of the patch out.

>> Source/WebCore/platform/graphics/win/SimpleFontDataCGWin.cpp:151
>> +    FontCascade::getGlyphAdvances(font, m, m_platformData.isSystemFont(), isPrinterFont, glyph, advance);
> 
> We have similarly named functions; I'd prefer putting the word "platform" inside the name of this function somewhere.

I'll change it to FontCascade::getPlatformGlyphAdvances(...)

[Brent Fulgham]

Committed r238253: <https://trac.webkit.org/changeset/238253>

[Brent Fulgham]

Build fix: https://trac.webkit.org/changeset/238256/webkit

[Brent Fulgham]

Follow-up build fix:
https://trac.webkit.org/changeset/238265/webkit