Bug 191699 - [GStreamer][WebRTC] Add API to enable/disable device mocks
Summary: [GStreamer][WebRTC] Add API to enable/disable device mocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-15 11:47 PST by Thibault Saunier
Modified: 2018-11-16 06:12 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.92 KB, patch)
2018-11-15 11:48 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch (12.87 KB, patch)
2018-11-15 12:48 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch for landing (13.01 KB, patch)
2018-11-16 05:31 PST, Thibault Saunier
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-11-15 11:47:31 PST
[GStreamer][WebRTC] Add API to enable/disable device mocks
Comment 1 Thibault Saunier 2018-11-15 11:48:35 PST
Created attachment 354965 [details]
Patch
Comment 2 Thibault Saunier 2018-11-15 12:48:21 PST
Created attachment 354973 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2018-11-15 23:41:36 PST
Comment on attachment 354973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354973&action=review

> Source/WebCore/ChangeLog:15
> +            stream is similare to what Apple port does.

similar

> Source/WebKit/ChangeLog:15
> +            stream is similare to what Apple port does.

similar

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:-163
> -    if (newSink == m_sink.get()) {
> -        GST_INFO_OBJECT(m_pipeline.get(), "Setting queue as leaky upstream"
> -            " so that the player can set the sink to PAUSED without "
> -            " setting the whole capturer to PAUSED");
> -        g_object_set(queue, "leaky", 2 /* upstream */, nullptr);
> -    }

If you remove this piece of code, you also want to remove one of the spaces, either below os above to avoid having a double empty line.
Comment 4 Thibault Saunier 2018-11-16 05:31:23 PST
Created attachment 355049 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-16 06:09:49 PST
Comment on attachment 355049 [details]
Patch for landing

Clearing flags on attachment: 355049

Committed r238278: <https://trac.webkit.org/changeset/238278>
Comment 6 WebKit Commit Bot 2018-11-16 06:09:51 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-11-16 06:12:09 PST
<rdar://problem/46125549>