Bug 191670 - Move scripts for Derived and Unified Sources to external files
Summary: Move scripts for Derived and Unified Sources to external files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-14 17:29 PST by Keith Rollin
Modified: 2018-11-14 22:01 PST (History)
10 users (show)

See Also:

Attachments
Patch (25.83 KB, patch)
2018-11-14 17:33 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
Rebase and try again (21.92 KB, patch)
2018-11-14 17:39 PST, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2018-11-14 17:29:21 PST 
Move the scripts in the Generate Derived Sources and Generate Unified Sources Run Script phases from the Xcode projects to external shell script files. Then invoke those scripts from the Run Script phases. This refactoring is being performed to support later work that will invoke these scripts in other contexts.

The scripts were maintained as-is when making the move. I did a little reformatting and added 'set -e' to the top of each file, but that's it.
Comment 1 Radar WebKit Bug Importer 2018-11-14 17:30:07 PST 
<rdar://problem/46082278>
Comment 2 Keith Rollin 2018-11-14 17:33:19 PST 
Created attachment 354877 [details]
Patch
Comment 3 Keith Rollin 2018-11-14 17:39:25 PST 
Created attachment 354878 [details]
Rebase and try again
Comment 4 Keith Miller 2018-11-14 19:22:29 PST 
Comment on attachment 354878 [details]
Rebase and try again

r=me.
Comment 5 WebKit Commit Bot 2018-11-14 22:01:22 PST 
Comment on attachment 354878 [details]
Rebase and try again

Clearing flags on attachment: 354878

Committed r238219: <https://trac.webkit.org/changeset/238219>
Comment 6 WebKit Commit Bot 2018-11-14 22:01:23 PST 
All reviewed patches have been landed.  Closing bug.