Bug 191664 - [ High Sierra+ ] Layout Test svg/animations/svglength-element-removed-crash.svg is flaky
Summary: [ High Sierra+ ] Layout Test svg/animations/svglength-element-removed-crash.s...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-14 16:01 PST by Truitt Savell
Modified: 2023-10-03 17:50 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.97 KB, patch)
2022-07-05 18:44 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (2.97 KB, patch)
2022-07-05 19:12 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (2.97 KB, patch)
2022-07-10 17:01 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Truitt Savell 2018-11-14 16:01:28 PST
The following layout test is flaky on High Sierra+

svg/animations/svglength-element-removed-crash.svg

Probable cause:

This test appears to have been failing for the whole history. 

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=svg%2Fanimations%2Fsvglength-element-removed-crash.svg

Diff:
--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/svg/animations/svglength-element-removed-crash-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/svg/animations/svglength-element-removed-crash-actual.txt
@@ -1 +1 @@
-PASS x = 10
+FAIL: -3 extra live node(s) x = 10
Comment 1 Truitt Savell 2018-12-11 09:52:44 PST
This test seems like it could be passing again as of around r238966 so issue may be resolved.
Comment 2 Fujii Hironori 2022-07-03 18:12:34 PDT
Another test failure:

Buildbot: builder Apple-BigSur-Debug-WK2-Tests build 7275: 251689@main
https://build.webkit.org/#/builders/23/builds/7275

 svg/animations/svglength-element-removed-crash.svg [ Failure ]

--- /Volumes/Data/worker/Apple-BigSur-Debug-WK2-Tests/build/layout-test-results/svg/animations/svglength-element-removed-crash-expected.txt
+++ /Volumes/Data/worker/Apple-BigSur-Debug-WK2-Tests/build/layout-test-results/svg/animations/svglength-element-removed-crash-actual.txt
@@ -1 +1 @@
-PASS x = 10
+FAIL: -136 extra live node(s) x = 10
Comment 3 Fujii Hironori 2022-07-05 18:44:47 PDT
Created attachment 460698 [details]
Patch
Comment 4 Fujii Hironori 2022-07-05 19:12:38 PDT
Created attachment 460699 [details]
Patch
Comment 5 Fujii Hironori 2022-07-10 17:01:12 PDT
Created attachment 460785 [details]
Patch
Comment 6 Fujii Hironori 2023-10-03 17:44:04 PDT
Comment on attachment 460785 [details]
Patch

Surprisingly, there is no flaky failure recently. We don't need this patch anymore.
https://results.webkit.org/?suite=layout-tests&test=svg%2Fanimations%2Fsvglength-element-removed-crash.svg
Comment 7 Fujii Hironori 2023-10-03 17:50:36 PDT
Closed.