Currently @media (prefers-color-scheme: light) is invalid on macOS before Mojave, but those systems only had light mode and we should match in that case. I'm not sure how common this case might be going forward, given that all other browsers don't support prefers-color-scheme yet.
<rdar://problem/46074680>
Seems worth doing.
Created attachment 358967 [details] Patch
Comment on attachment 358967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=358967&action=review > Source/WebCore/page/Page.cpp:2679 > } Does 'value' not need to be marked as UNUSED? > Source/WebCore/page/Page.cpp:2704 > +#endif Does 'valueOverride' not need to be marked as UNUSED?
Created attachment 358982 [details] Patch
Created attachment 358992 [details] Patch
Created attachment 358993 [details] Patch
Comment on attachment 358993 [details] Patch Attachment 358993 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/10728673 New failing tests: css-dark-mode/older-systems/supported-color-schemes-css.html css-dark-mode/older-systems/supported-color-schemes.html
Created attachment 358997 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Created attachment 358998 [details] Patch
Comment on attachment 358998 [details] Patch Clearing flags on attachment: 358998 Committed r239904: <https://trac.webkit.org/changeset/239904>
All reviewed patches have been landed. Closing bug.