Bug 191655 - Have prefers-color-scheme: light always match on macOS versions before Mojave
Summary: Have prefers-color-scheme: light always match on macOS versions before Mojave
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-14 14:05 PST by Timothy Hatcher
Modified: 2019-01-12 21:54 PST (History)
7 users (show)

See Also:


Attachments
Patch (42.26 KB, patch)
2019-01-11 17:31 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (42.32 KB, patch)
2019-01-11 21:33 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (46.27 KB, patch)
2019-01-12 10:06 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (42.94 KB, patch)
2019-01-12 10:29 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.61 MB, application/zip)
2019-01-12 17:11 PST, EWS Watchlist
no flags Details
Patch (42.94 KB, patch)
2019-01-12 18:18 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-11-14 14:05:38 PST
Currently @media (prefers-color-scheme: light) is invalid on macOS before Mojave, but those systems only had light mode and we should match in that case. I'm not sure how common this case might be going forward, given that all other browsers don't support prefers-color-scheme yet.
Comment 1 Radar WebKit Bug Importer 2018-11-14 14:06:02 PST
<rdar://problem/46074680>
Comment 2 Simon Fraser (smfr) 2018-11-14 14:06:44 PST
Seems worth doing.
Comment 3 Timothy Hatcher 2019-01-11 17:31:04 PST Comment hidden (obsolete)
Comment 4 Megan Gardner 2019-01-11 17:40:18 PST
Comment on attachment 358967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=358967&action=review

> Source/WebCore/page/Page.cpp:2679
>  }

Does 'value' not need to be marked as UNUSED?

> Source/WebCore/page/Page.cpp:2704
> +#endif

Does 'valueOverride' not need to be marked as UNUSED?
Comment 5 Timothy Hatcher 2019-01-11 21:33:20 PST Comment hidden (obsolete)
Comment 6 Timothy Hatcher 2019-01-12 10:06:30 PST Comment hidden (obsolete)
Comment 7 Timothy Hatcher 2019-01-12 10:29:11 PST Comment hidden (obsolete)
Comment 8 EWS Watchlist 2019-01-12 17:11:37 PST Comment hidden (obsolete)
Comment 9 EWS Watchlist 2019-01-12 17:11:39 PST Comment hidden (obsolete)
Comment 10 Timothy Hatcher 2019-01-12 18:18:03 PST
Created attachment 358998 [details]
Patch
Comment 11 WebKit Commit Bot 2019-01-12 21:54:13 PST
Comment on attachment 358998 [details]
Patch

Clearing flags on attachment: 358998

Committed r239904: <https://trac.webkit.org/changeset/239904>
Comment 12 WebKit Commit Bot 2019-01-12 21:54:14 PST
All reviewed patches have been landed.  Closing bug.