libcurl silently add some headers and those are not displayed in Web Inspector.
Created attachment 371380 [details] Patch
We should add resource-request-headers-expected.txt for WinCairo platform because output strings between DRT and WebKitTestRunner are slight different. WebKitTestRunner adds extra authentication scheme string in TestController::didReceiveAuthenticationChallenge. Added resource-request-headers-expected.txt is the same as the result of gtk port.
Comment on attachment 371380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371380&action=review > Source/WebCore/ChangeLog:8 > + LayoutTests/http/tests/inspector/network/resource-request-headers.html Add 'Tests:'. Remove 'LayoutTests/'. > Source/WebCore/platform/network/curl/CurlRequest.cpp:509 > + for (auto header : headerFields) { Use 'auto&' to avoid unnecessary ref-ing.
Created attachment 371462 [details] Patch
(In reply to Fujii Hironori from comment #3) > Comment on attachment 371380 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371380&action=review > > > Source/WebCore/ChangeLog:8 > > + LayoutTests/http/tests/inspector/network/resource-request-headers.html > > Add 'Tests:'. > Remove 'LayoutTests/'. Fixed. > > Source/WebCore/platform/network/curl/CurlRequest.cpp:509 > > + for (auto header : headerFields) { > > Use 'auto&' to avoid unnecessary ref-ing. Fixed.
Comment on attachment 371462 [details] Patch Clearing flags on attachment: 371462 Committed r246143: <https://trac.webkit.org/changeset/246143>
All reviewed patches have been landed. Closing bug.
<rdar://problem/51468215>
Comment on attachment 371462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371462&action=review > LayoutTests/platform/wincairo/TestExpectations:896 > +http/tests/inspector/network/resource-request-headers.html [ Pass ] http/tests/inspector/network/resource-request-headers.html is timing out on BuildBot. https://build.webkit.org/results/WinCairo%2064-bit%20WKL%20Release%20(Tests)/r246388%20(4218)/results.html