Currently empty body.
Created attachment 361772 [details]
When server returns 401 error WinCairo port doesn't print any result.
When 401 error we should call didReceiveResponse.
This patch fix it.
Comment on attachment 361772 [details]
Attachment 361772 [details] did not pass mac-debug-ews (mac):
New failing tests:
Created attachment 361780 [details]
Archive of layout-test-results from ews112 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Does this fix some layout tests? That should be mentioned in the ChangeLog.
Created attachment 361873 [details]
(In reply to Alex Christensen from comment #5)
> Does this fix some layout tests? That should be mentioned in the ChangeLog.
This patch doesn't fix existing layouttest.
This fixes the behavior of server returning 401, and testrunner can't handle it.
Because testrunner challenges authentication infinitely when auth fails.
Is there apropriate test for this situation?
(In reply to Takashi Komori from comment #7)
> Is there apropriate test for this situation?
There are many tests where servers return 401. If there isn't a test that this change fixes, there should be. I'll be there's already at least one, and it should be mentioned.
Created attachment 362976 [details]
(In reply to Alex Christensen from comment #8)
Thank you for your comment.
New patch passes http/tests/security/401-logout/401-logout.php
Expected results for WebKitTestRunner and DumpRenderTree are different.
This is because difference of didReceiveAuthenticationChallenge implementations between TestRunner and DRT.
On WIncairo port, we should use LayoutTests/http/tests/security/401-logout/401-logout-expected.txt as DumpRenderTree's expected result,
and use LayoutTests/platform/wk2/http/tests/security/401-logout/401-logout-expected.txt as WebKitTestRunner's expected result.
Comment on attachment 362976 [details]
Clearing flags on attachment: 362976
Committed r242092: <https://trac.webkit.org/changeset/242092>
All reviewed patches have been landed. Closing bug.