Bug 191651 - [Curl] HTTP Body is missing with redirection.
Summary: [Curl] HTTP Body is missing with redirection.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-14 12:57 PST by Basuke Suzuki
Modified: 2019-02-28 10:45 PST (History)
10 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2019-02-28 00:25 PST, Takashi Komori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2018-11-14 12:57:43 PST 
When sending a request with HTTP Body on POST, and receive 307 "Temporary Redirect", http body is not be on new request. Will implement ResourceRequest::updateFromDelegatePreservingOldProperties .
Comment 1 Takashi Komori 2019-02-28 00:25:53 PST 
Created attachment 363199 [details]
Patch
Comment 2 Takashi Komori 2019-02-28 00:28:18 PST 
Implement updateFromDelegatePreservingOldProperties for curl port.
This patch fixes some post tests.
Comment 3 Basuke Suzuki 2019-02-28 10:16:52 PST 
Comment on attachment 363199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363199&action=review

This is just an informal review, but looks good to me.

> Source/WebCore/platform/network/curl/ResourceRequestCurl.cpp:34
> +void ResourceRequest::updateFromDelegatePreservingOldProperties(const ResourceRequest& delegateProvidedRequest)

This seems identical to CFNet port and good catch to align with other network port. Thank you.
Comment 4 WebKit Commit Bot 2019-02-28 10:44:55 PST 
Comment on attachment 363199 [details]
Patch

Clearing flags on attachment: 363199

Committed r242207: <https://trac.webkit.org/changeset/242207>
Comment 5 WebKit Commit Bot 2019-02-28 10:44:56 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-28 10:45:44 PST 
<rdar://problem/48479924>