Bug 191642 – REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key-case-insensitive.html are timing out

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Antti Koivisto]

The changes in https://trac.webkit.org/changeset/238178/webkit

has caused these two tests to begin timing out on MacOS Release WK2:
fast/forms/access-key-mutated.html 
fast/forms/access-key-case-insensitive.html

Repro Command:
run-webkit-tests --root testbuild-238178 fast/forms/access-key-mutated.html fast/forms/access-key-case-insensitive.html --iterations 5 -f

[Truitt Savell]

additionally accessibility/mac/selection-notification-focus-change.html

is also failing constantly now in those same configurations

History
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Fselection-notification-focus-change.html

Diff:
--- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/accessibility/mac/selection-notification-focus-change-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/accessibility/mac/selection-notification-focus-change-actual.txt
@@ -7,9 +7,9 @@
 eventSender.keyDown(tabCharacter);
 Received AXSelectedTextChanged
 PASS userInfo["AXTextSelectionChangedFocus"] is true
+Received AXFocusChanged
 Received AXSelectedTextChanged
 PASS userInfo["AXTextSelectionChangedFocus"] is true
-Received AXFocusChanged
 
 PASS accessibilityController.accessibleElementById("1").isFocusable is true
 accessibilityController.accessibleElementById("1").takeFocus()

[Antti Koivisto]

Skipped that too in https://trac.webkit.org/r238189

[Truitt Savell]

Looks like this is going to effect debug too. fast/forms/access-key-case-insensitive.html and fast/forms/access-key-mutated.html shows a timeout on Sierra Debug WK2

[Antti Koivisto]

The tests are skipped on all platforms

[Ryan Haddad]

(In reply to Antti Koivisto from comment #2)
> Skipped that too in https://trac.webkit.org/r238189
Moved the skip to mac-wk2 in https://trac.webkit.org/r238194 (since accessibility/mac is marked as pass in platform/mac, r238189 didn't do anything).

[Antti Koivisto]

Created attachment 354902 [details]
patch

[WebKit Commit Bot]

Comment on attachment 354902 [details]
patch

Rejecting attachment 354902 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 354902, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: https://webkit-queues.webkit.org/results/10002856

[Antti Koivisto]

https://trac.webkit.org/r238223

[Radar WebKit Bug Importer]

<rdar://problem/46093834>

[Simon Fraser (smfr)]

Comment on attachment 354902 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354902&action=review

> Source/WebCore/dom/Document.cpp:1808
> +    // FIXME: Why on earth is this here? This is clearly misplaced.
> +    invalidateAccessKeyMap();

Hahahah