Bug 191623 - [LFC][IFC] Construct dedicated runs when the inline element requires it (part 2)
Summary: [LFC][IFC] Construct dedicated runs when the inline element requires it (part 2)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 21:29 PST by zalan
Modified: 2018-11-14 07:33 PST (History)
5 users (show)

See Also:


Attachments
Patch (15.20 KB, patch)
2018-11-13 21:48 PST, zalan
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-11-13 21:29:34 PST
expanding original breaking behavior with separate left/right
Comment 1 zalan 2018-11-13 21:48:38 PST
Created attachment 354769 [details]
Patch
Comment 2 Antti Koivisto 2018-11-14 06:44:46 PST
Comment on attachment 354769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354769&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:420
> +    std::function<void(const Box&)> collectInlineContentForSubtree = [&](const Box& root) {

We usually use WTF::Function in WebKit. Also invoking these has a cost since it involves a virtual function. It might be better to factor into a regular function when this becomes necessary.
Comment 3 zalan 2018-11-14 07:31:25 PST
Committed r238173: <https://trac.webkit.org/changeset/238173>
Comment 4 Radar WebKit Bug Importer 2018-11-14 07:33:32 PST
<rdar://problem/46062578>