RESOLVED FIXED 191623
[LFC][IFC] Construct dedicated runs when the inline element requires it (part 2) 
https://bugs.webkit.org/show_bug.cgi?id=191623
Summary [LFC][IFC] Construct dedicated runs when the inline element requires it (part 2)
zalan
Reported 2018-11-13 21:29:34 PST
expanding original breaking behavior with separate left/right
Attachments
Patch (15.20 KB, patch)
2018-11-13 21:48 PST, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-11-13 21:48:38 PST
Created attachment 354769 [details] Patch
Antti Koivisto
Comment 2 2018-11-14 06:44:46 PST
Comment on attachment 354769 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354769&action=review > Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp:420 > + std::function<void(const Box&)> collectInlineContentForSubtree = [&](const Box& root) { We usually use WTF::Function in WebKit. Also invoking these has a cost since it involves a virtual function. It might be better to factor into a regular function when this becomes necessary.
zalan
Comment 3 2018-11-14 07:31:25 PST
Committed r238173: <https://trac.webkit.org/changeset/238173>
Radar WebKit Bug Importer
Comment 4 2018-11-14 07:33:32 PST
<rdar://problem/46062578>
Note You need to log in before you can comment on or make changes to this bug.