Bug 191620 - [curl] Unify CookieJarCurlDatabase and the abstract class CookieJarCurl
Summary: [curl] Unify CookieJarCurlDatabase and the abstract class CookieJarCurl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 19:19 PST by Fujii Hironori
Modified: 2018-11-14 08:15 PST (History)
7 users (show)

See Also:

Attachments
Patch (25.49 KB, patch)
2018-11-13 19:26 PST, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-11-13 19:19:46 PST 
[curl] Unify CookieJarCurlDatabase and the abstract class CookieJarCurl

Based on the Basuke's comment.

(In reply to Basuke Suzuki from bug #191582 comment #3)
> > I'm honestly wondering why there's a CookieJarCurl at all. There's no cpp
> > file and I just see an implementation in CookieJarCurlDatabase. Maybe this
> > should just be collapsed?
> 
> This must be the left over of cookie backend abstraction. It had been a file
> based storage and when the introduction of sqlite based backend, the
> clients, such as NetworkStorageSession,  just used interface to communicate
> with backend.
> 
> I agree with removing this abstraction because we already took out the file
> based backend.
Comment 1 Fujii Hironori 2018-11-13 19:26:01 PST 
Created attachment 354754 [details]
Patch
Comment 2 Don Olmstead 2018-11-13 21:01:56 PST 
LGTM
Comment 3 WebKit Commit Bot 2018-11-14 08:14:25 PST 
Comment on attachment 354754 [details]
Patch

Clearing flags on attachment: 354754

Committed r238176: <https://trac.webkit.org/changeset/238176>
Comment 4 WebKit Commit Bot 2018-11-14 08:14:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-11-14 08:15:27 PST 
<rdar://problem/46063373>