Bug 191614 – [SOUP] Make Accept-Languages header look more like other browsers

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Remove extra spaces from Accept-Languages header


Firefox header:

Accept-Language: en-US,en;q=0.7,es-ES;q=0.3

Chrome header:

Accept-Language: en-US,en;q=0.9,es;q=0.8

Epiphany before:

Accept-Language: en-us, en;q=0.90, es-es;q=0.80, es;q=0.70

Epiphany after:

Accept-Language: en-us,en;q=0.90,es-es;q=0.80,es;q=0.70


(Probably should stop lowercasing it too, but that's Epiphany, not WebKit, doing that.)

[Michael Catanzaro]

Created attachment 354738 [details]
Patch

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #0)
> (Probably should stop lowercasing it too, but that's Epiphany, not WebKit,
> doing that.)

Actually we have redundant code in both Epiphany and WebKit to do this.

I'm not sure why. Clearly other browsers do not downcase the languages.

[Michael Catanzaro]

Created attachment 354748 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Commit Bot]

Comment on attachment 354748 [details]
Patch

Clearing flags on attachment: 354748

Committed r238236: <https://trac.webkit.org/changeset/238236>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.