Bug 191614 - [SOUP] Make Accept-Languages header look more like other browsers
Summary: [SOUP] Make Accept-Languages header look more like other browsers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-13 17:32 PST by Michael Catanzaro
Modified: 2018-11-15 11:44 PST (History)
7 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2018-11-13 17:42 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2018-11-13 18:26 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-11-13 17:32:42 PST
Remove extra spaces from Accept-Languages header


Firefox header:

Accept-Language: en-US,en;q=0.7,es-ES;q=0.3

Chrome header:

Accept-Language: en-US,en;q=0.9,es;q=0.8

Epiphany before:

Accept-Language: en-us, en;q=0.90, es-es;q=0.80, es;q=0.70

Epiphany after:

Accept-Language: en-us,en;q=0.90,es-es;q=0.80,es;q=0.70


(Probably should stop lowercasing it too, but that's Epiphany, not WebKit, doing that.)
Comment 1 Michael Catanzaro 2018-11-13 17:42:59 PST
Created attachment 354738 [details]
Patch
Comment 2 Michael Catanzaro 2018-11-13 17:54:06 PST
(In reply to Michael Catanzaro from comment #0)
> (Probably should stop lowercasing it too, but that's Epiphany, not WebKit,
> doing that.)

Actually we have redundant code in both Epiphany and WebKit to do this.

I'm not sure why. Clearly other browsers do not downcase the languages.
Comment 3 Michael Catanzaro 2018-11-13 18:26:06 PST
Created attachment 354748 [details]
Patch
Comment 4 EWS Watchlist 2018-11-13 18:29:50 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 5 WebKit Commit Bot 2018-11-15 11:44:06 PST
Comment on attachment 354748 [details]
Patch

Clearing flags on attachment: 354748

Committed r238236: <https://trac.webkit.org/changeset/238236>
Comment 6 WebKit Commit Bot 2018-11-15 11:44:08 PST
All reviewed patches have been landed.  Closing bug.