Bug 191605 - [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -makeTextWritingDirectionNatural:)
Summary: [Cocoa] [WebKit2] Hook up some more editing actions (-pasteAndMatchStyle:, -m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 15:26 PST by Wenson Hsieh
Modified: 2018-11-14 11:01 PST (History)
6 users (show)

See Also:

Attachments
Patch (13.38 KB, patch)
2018-11-13 16:48 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix non-internal iOS build (13.87 KB, patch)
2018-11-14 07:31 PST, Wenson Hsieh 		dino: review+
Details | Formatted Diff | Diff
Patch for landing (13.97 KB, patch)
2018-11-14 10:21 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-11-13 15:26:21 PST 
<rdar://problem/45813991>
Comment 1 Wenson Hsieh 2018-11-13 16:48:18 PST 
Created attachment 354730 [details]
Patch
Comment 2 Wenson Hsieh 2018-11-14 07:31:50 PST 
Created attachment 354808 [details]
Fix non-internal iOS build
Comment 3 Wenson Hsieh 2018-11-14 10:14:40 PST 
Comment on attachment 354808 [details]
Fix non-internal iOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=354808&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:250
> +    auto destination = webViewForEditActionTesting(@"<div><br></div>");

Hm...I just realized, I might have to tweak this test a bit to work around <https://webkit.org/b/190401>. I'm going to move this line:

    `auto destination = webViewForEditActionTesting(@"<div><br></div>");`

...to right after we create the source WKWebView in `auto source = webViewForEditActionTesting();`.
Comment 4 Wenson Hsieh 2018-11-14 10:21:34 PST 
Created attachment 354828 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-11-14 11:00:13 PST 
Comment on attachment 354828 [details]
Patch for landing

Clearing flags on attachment: 354828

Committed r238186: <https://trac.webkit.org/changeset/238186>