RESOLVED FIXED 191604
Add SPI to show a safe browsing warning 
https://bugs.webkit.org/show_bug.cgi?id=191604
Summary Add SPI to show a safe browsing warning
Alex Christensen
Reported 2018-11-13 15:14:44 PST
Add SPI to show a safe browsing warning
Attachments
Patch (84.56 KB, patch)
2018-11-13 15:23 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (84.56 KB, patch)
2018-11-13 16:02 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (83.44 KB, patch)
2018-11-14 10:36 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (82.97 KB, patch)
2018-11-14 10:49 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-11-13 15:23:46 PST
Created attachment 354709 [details] Patch
Alex Christensen
Comment 2 2018-11-13 16:02:11 PST
Created attachment 354721 [details] Patch
Andy Estes
Comment 3 2018-11-14 10:25:37 PST
Comment on attachment 354721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354721&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1285 > -- (void)_showSafeBrowsingWarning:(const WebKit::SafeBrowsingResult&)result completionHandler:(CompletionHandler<void(Variant<WebKit::ContinueUnsafeLoad, WebCore::URL>&&)>&&)completionHandler > +- (void)_showSafeBrowsingWarningWithTitle:(NSString *)title warning:(NSString *)warning details:(NSAttributedString *)details completionHandler:(void(^)(BOOL, NSURL *))completionHandler > { > - _safeBrowsingWarning = adoptNS([[WKSafeBrowsingWarning alloc] initWithFrame:self.bounds safeBrowsingResult:result completionHandler:[weakSelf = WeakObjCPtr<WKWebView>(self), completionHandler = WTFMove(completionHandler)] (auto&& result) mutable { > + > +} Oops?
Alex Christensen
Comment 4 2018-11-14 10:36:54 PST
Created attachment 354832 [details] Patch
Alex Christensen
Comment 5 2018-11-14 10:49:59 PST
Created attachment 354836 [details] Patch
Alex Christensen
Comment 6 2018-11-14 11:47:13 PST
http://trac.webkit.org/r238190
Radar WebKit Bug Importer
Comment 7 2018-11-14 11:48:24 PST
<rdar://problem/46070191>
Note You need to log in before you can comment on or make changes to this bug.