Bug 191603 - Calling removeTrack on different RTCPeerConnection should throw InvalidAccessError
Summary: Calling removeTrack on different RTCPeerConnection should throw InvalidAccess...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 15:08 PST by youenn fablet
Modified: 2018-11-14 09:36 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.62 KB, patch)
2018-11-13 15:10 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (2.54 MB, application/zip)
2018-11-13 17:31 PST, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-sierra-wk2 (3.13 MB, application/zip)
2018-11-13 17:57 PST, Build Bot
no flags Details
Patch (8.51 KB, patch)
2018-11-14 06:30 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-11-13 15:08:39 PST
Calling removeTrack on different RTCPeerConnection should throw InvalidAccessError
Comment 1 youenn fablet 2018-11-13 15:10:15 PST
Created attachment 354707 [details]
Patch
Comment 2 Build Bot 2018-11-13 17:31:42 PST
Comment on attachment 354707 [details]
Patch

Attachment 354707 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9979265

New failing tests:
fast/mediastream/RTCPeerConnection-add-removeTrack.html
Comment 3 Build Bot 2018-11-13 17:31:44 PST
Created attachment 354734 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 4 Build Bot 2018-11-13 17:57:34 PST
Comment on attachment 354707 [details]
Patch

Attachment 354707 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/9979932

New failing tests:
fast/mediastream/RTCPeerConnection-add-removeTrack.html
Comment 5 Build Bot 2018-11-13 17:57:35 PST
Created attachment 354744 [details]
Archive of layout-test-results from ews105 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 youenn fablet 2018-11-14 06:30:43 PST
Created attachment 354802 [details]
Patch
Comment 7 Chris Dumez 2018-11-14 08:43:46 PST
Comment on attachment 354802 [details]
Patch

r=me
Comment 8 WebKit Commit Bot 2018-11-14 09:35:10 PST
Comment on attachment 354802 [details]
Patch

Clearing flags on attachment: 354802

Committed r238180: <https://trac.webkit.org/changeset/238180>
Comment 9 WebKit Commit Bot 2018-11-14 09:35:12 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-11-14 09:36:26 PST
<rdar://problem/46065351>