Bug 191600 – TypeProfileLog::processLogEntries should stash away any pending exceptions and re-apply them to the VM

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

processLogEntries will call into calculatedClassName, which will clear any pending exceptions (it assumes that they're stack overflow exceptions). However, this code may be called when an exception is already pending on the VM. To get around this, processLogEntires should stash away and re-apply any pending exceptions.

[Saam Barati]

Created attachment 354706 [details]
patch

[Mark Lam]

Comment on attachment 354706 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354706&action=review

r=me with fixes.

> Source/JavaScriptCore/runtime/TypeProfilerLog.cpp:63
> +    // thrown, so we don't calcualtedDisplayName to clear that exception that

/don't/don't want/

> Source/JavaScriptCore/runtime/VM.h:901
> +            : m_savedException(vm.m_exception)
> +            , m_savedLastException(vm.m_lastException)

This should be:
            : m_savedException(vm.m_exception, nullptr)
            , m_savedLastException(vm.m_lastException, nullptr)

Otherwise, you would not be "deferring" the exception.

[Saam Barati]

Created attachment 354715 [details]
patch for landing

[Saam Barati]

<rdar://problem/45517293>

[WebKit Commit Bot]

Comment on attachment 354715 [details]
patch for landing

Clearing flags on attachment: 354715

Committed r238162: <https://trac.webkit.org/changeset/238162>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.