Bug 191598 - Transform of composited layer not updated when layer also needs repaint
Summary: Transform of composited layer not updated when layer also needs repaint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ali Juma
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-11-13 13:22 PST by Ali Juma
Modified: 2018-11-14 05:14 PST (History)
6 users (show)

See Also:


Attachments
Test case (459 bytes, text/html)
2018-11-13 13:22 PST, Ali Juma
no flags Details
Patch (4.21 KB, patch)
2018-11-13 13:26 PST, Ali Juma
no flags Details | Formatted Diff | Diff
Patch for landing (4.20 KB, patch)
2018-11-13 14:25 PST, Ali Juma
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2018-11-13 13:22:50 PST
Created attachment 354693 [details]
Test case

After the changes to compositing in bug 90342, a style change that affects a composited layer's transform and simultaneously changes another property triggering repaint will no longer trigger a compositing geometry update, so the GraphicsLayer's transform never gets updated.

For example, after changing both the background-color and the transform of a composited layer, the layer gets repainted with the new color but doesn't move.
Comment 1 Ali Juma 2018-11-13 13:26:32 PST
Created attachment 354695 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-11-13 14:10:11 PST
Comment on attachment 354695 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354695&action=review

Nice, thanks for the fix.

> LayoutTests/compositing/geometry/transform-and-repaint-updates-geometry.html:22
> +requestAnimationFrame(function() { 

() =>
Comment 3 Ali Juma 2018-11-13 14:25:55 PST
Created attachment 354702 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2018-11-14 05:13:24 PST
Comment on attachment 354702 [details]
Patch for landing

Clearing flags on attachment: 354702

Committed r238170: <https://trac.webkit.org/changeset/238170>
Comment 5 WebKit Commit Bot 2018-11-14 05:13:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-11-14 05:14:24 PST
<rdar://problem/46060367>