Pressing Shift + Tab does not focus the previous field on facebook.com. Steps to reproduce: The following assume that a hardware keyboard is attached. 1. Visit <https://www.facebook.com>. 2. Tap the password field. 3. Press Shift + Tab. Then the Email or Phone field should be focused. But there is no change in focus.
<rdar://problem/45892053>
Created attachment 354699 [details] Patch and layout tests
Comment on attachment 354699 [details] Patch and layout tests View in context: https://bugs.webkit.org/attachment.cgi?id=354699&action=review r=me, with non-internal iOS builds fixed > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2427 > + return [self isFirstResponder]; Have you considered consulting `AssistedNodeInformation.hasNextNode` or `AssistedNodeInformation.hasPreviousNode` as well?
Comment on attachment 354699 [details] Patch and layout tests View in context: https://bugs.webkit.org/attachment.cgi?id=354699&action=review > Tools/ChangeLog:21 > + and an array of modifier keys. The behavior of this function is analagous to eventSender.keyDown(). Nit - analagous => analogous > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:405 > + // Character can be either a single Unicode code point or a the name of a special key (e.g. "downArrow"). Nit - "or a the"
Created attachment 354728 [details] For EWS
Comment on attachment 354728 [details] For EWS For EWS. Need to address review feedback.
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 354699 [details] > Patch and layout tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354699&action=review > > r=me, with non-internal iOS builds fixed > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2427 > > + return [self isFirstResponder]; > > Have you considered consulting `AssistedNodeInformation.hasNextNode` or > `AssistedNodeInformation.hasPreviousNode` as well? Will write in terms of AssistedNodeInformation.has{Next, Previous}Node such that the beginning of -canPerformActionForWebView reads: [[ - (BOOL)canPerformActionForWebView:(SEL)action withSender:(id)sender { { if (action == @selector(_nextAccessoryTab:)) return hasAssistedNode(_assistedNodeInformation) && _assistedNodeInformation.hasNextNode; if (action == @selector(_previousAccessoryTab:)) return hasAssistedNode(_assistedNodeInformation) && _assistedNodeInformation.hasPreviousNode; ... ]]
(In reply to Wenson Hsieh from comment #4) > Comment on attachment 354699 [details] > Patch and layout tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354699&action=review > > > Tools/ChangeLog:21 > > + and an array of modifier keys. The behavior of this function is analagous to eventSender.keyDown(). > > Nit - analagous => analogous > Will fix. > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:405 > > + // Character can be either a single Unicode code point or a the name of a special key (e.g. "downArrow"). > > Nit - "or a the" Will fix.
Created attachment 354957 [details] To Land
Committed r238235: <https://trac.webkit.org/changeset/238235>